GNOME Bugzilla – Bug 739965
validate: Assumes first buffer should have a running time of 0
Last modified: 2015-06-24 14:44:16 UTC
In gst_validate_pad_monitor_check_first_buffer() there is a check that asserts that the first buffer's running time should always be 0. This is not correct in at least two cases: - live pipelines - container files where e.g. the audio stream starts a bit later than the video stream, thus the first audio running time is > 0
OK, I was wondering also, we should just remove that check then or can you think of a way to properly check that?
What do you want to check for? :) I can't think of anything generic that could be checked there
Created attachment 290431 [details] [review] validate: Do not check if first buffer running time is 0 It can perfectly not be 0, so it makes no sense to check that.
Comment on attachment 290431 [details] [review] validate: Do not check if first buffer running time is 0 Looks good... but that means you're not committed to a stable API for gst-validate (yet)?
There are very few APIs that are declared stable, they are the ones that have been documented, the rest is still "moving". That is what I explained in the release notes.
Attachment 290431 [details] pushed as 7f8c0c2 - validate: Do not check if first buffer running time is 0