After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739931 - removable drive menu fails to launch filesystem browser
removable drive menu fails to launch filesystem browser
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-11-10 23:10 UTC by Matthew Gabeler-Lee
Modified: 2014-11-12 18:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
drive-menu: Adjust for renamed .desktop file name (1.06 KB, patch)
2014-11-12 18:53 UTC, Florian Müllner
committed Details | Review
drive-menu: Update for gnome-shell changes (1.04 KB, patch)
2014-11-12 18:53 UTC, Florian Müllner
committed Details | Review

Description Matthew Gabeler-Lee 2014-11-10 23:10:29 UTC
If I click on one of the removable drive entries, I get:

(gnome-shell:3075): Gjs-WARNING **: JS ERROR: Error: Too few arguments to method Shell.create_app_launch_context expected 2 got 0
MountMenuItem<.activate@/usr/share/gnome-shell/extensions/drive-menu@gnome-shell-extensions.gcampax.github.com/extension.js:112
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
PopupBaseMenuItem<._onButtonReleaseEvent@resource:///org/gnome/shell/ui/popupMenu.js:118
wrapper@resource:///org/gnome/gjs/modules/lang.js:169

And if I click the "Open File" entry (which is at best a confusing label, maybe a typo for Open Files?), I get:

(gnome-shell:3075): Gjs-WARNING **: JS ERROR: Exception in callback for signal: activate: TypeError: app is null
DriveMenu<._init/<@/usr/share/gnome-shell/extensions/drive-menu@gnome-shell-extensions.gcampax.github.com/extension.js:153
PopupMenuBase<.addAction/<@resource:///org/gnome/shell/ui/popupMenu.js:447
_emit@resource:///org/gnome/gjs/modules/signals.js:124
PopupBaseMenuItem<.activate@resource:///org/gnome/shell/ui/popupMenu.js:153
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
PopupBaseMenuItem<._onButtonReleaseEvent@resource:///org/gnome/shell/ui/popupMenu.js:118
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
Comment 1 Florian Müllner 2014-11-12 18:53:14 UTC
The following fixes have been pushed:
4da3668 drive-menu: Adjust for renamed .desktop file name
109bdd1 drive-menu: Update for gnome-shell changes
Comment 2 Florian Müllner 2014-11-12 18:53:20 UTC
Created attachment 290536 [details] [review]
drive-menu: Adjust for renamed .desktop file name

Nautilus now uses reverse domain notation for its .desktop file,
adjust for that.
Comment 3 Florian Müllner 2014-11-12 18:53:27 UTC
Created attachment 290537 [details] [review]
drive-menu: Update for gnome-shell changes

Since shell commit 3227d4f3edad, Shell.Global.create_app_launch_context()
expects additional parameters.