GNOME Bugzilla – Bug 739891
Mapping of display-less tablets sometimes stick to older settings
Last modified: 2014-11-11 14:49:50 UTC
I'm attaching some patches that: - Make sure that display-less tablets can be set back to mapping to the full desktop extent - Make sure that the output is looked up again from settings when the connected outputs change The first patch is a minor refactor for these 2 fixes.
Created attachment 290353 [details] [review] common: Refactor output-from-settings input device configuration. The code that handled this when creating a GsdInputInfo and whenever the settings changed were almost the same, put it in a common place.
Created attachment 290354 [details] [review] common: Unset output-from-settings if no matching output is found This ensures that either an output is guessed for the device again, or for display-less tablets, the default matrix spanning full desktop extents is reinstaurated.
Created attachment 290355 [details] [review] common: Update output-from-settings when the outputs change Outputs being connected/disconnected should update the input devices that are mapped to these through config, so they are remapped/unmapped correctly after the change.
Review of attachment 290353 [details] [review]: nice
Review of attachment 290354 [details] [review]: looks good
Review of attachment 290355 [details] [review]: makes sense
Carlos, this seems like it should go in for 3.14.2 too, right?
(In reply to comment #7) > Carlos, this seems like it should go in for 3.14.2 too, right? Yep :), will push to both master and gnome-3-14
Attachment 290353 [details] pushed as 6597c36 - common: Refactor output-from-settings input device configuration. Attachment 290354 [details] pushed as 7f3955b - common: Unset output-from-settings if no matching output is found Attachment 290355 [details] pushed as f0e5d24 - common: Update output-from-settings when the outputs change