GNOME Bugzilla – Bug 739871
change default size for avatar cropping
Last modified: 2014-11-25 14:25:58 UTC
Created attachment 290328 [details] [review] Change default size for avatar cropping Change default size for avatar cropping to correspond with changes in cheese. The default size should be based on maximal size of the image (Bug 710874) instead of minimal size for cropping. It has to be also limited to fit size of image (to avoid crashes), see Bug 739870 for cheese for more details.
The patch for cheese was already accepted and pushed...
Review of attachment 290328 [details] [review]: ::: panels/user-accounts/cc-crop-area.c @@ +149,3 @@ + + /* Scale the crop rectangle to 80% of the size of pixbuf, or less to fit the current crop area */ + crop_scale = MIN (MIN ((gdouble)gdk_pixbuf_get_width (area->priv->pixbuf) / area->priv->base_width * 0.8, This is unreadable.
Created attachment 291444 [details] [review] user-accounts: change default size for avatar cropping There is new patch, it does same thing as the one from cheese, however it is just "reformatted". Is the patch still unreadable (first part is from your commit to cheese)?
Created attachment 291445 [details] what it is doing There is screenshot...
Comment on attachment 291444 [details] [review] user-accounts: change default size for avatar cropping Have made some change before attaching and it wasn't working like intended now, it needs some changes...
Created attachment 291450 [details] [review] user-accounts: change default size for avatar cropping Wrong variable name, it should be fixed now...
Review of attachment 291450 [details] [review]: Much better, thanks.
Comment on attachment 291450 [details] [review] user-accounts: change default size for avatar cropping commit 33052abe9c3db34c502d7f28938d169a2f540247
Thanks for review!
Comment on attachment 291450 [details] [review] user-accounts: change default size for avatar cropping Also for gnome-3-14: commit a162ccb53407315b7993bd39a0f37dc3b1f08a61