GNOME Bugzilla – Bug 739862
[PATCH] Port the gimp Exchange Color plug-in
Last modified: 2014-11-10 21:42:34 UTC
Created attachment 290289 [details] [review] new gegl:color-exchange operation This patch contains gegl implementation of the Exchange Color Gimp plugin. It also adds xml composition for testing and the related reference image.
Thanks! prepare() is called whenever a property changes, so you can move that logic into prepare(), you normally don't need a notify() implementation in a GEGL op.
ok (I use the notify() mechanism after taking inspiration from the color-temperature operation) Now, what is best : - a totaly new patch with the correct implementation or - a corrective patch related to the first one ?
Indeed, but it's just as redundant there and should be fixed. We prefer new patches, and you would mark the old patch as obsolete when attaching the new patch.
Created attachment 290374 [details] [review] new gegl:color-exchange operation notify() implementation removed ; logic moved to prepare()
*** Bug 726557 has been marked as a duplicate of this bug. ***
I meant to test this but said git push in the wrong tree, so there we go... Let's address possible bugs/changes in git directly. commit 2217e4f95577943355b976b9189af2ddecc5f100 Author: Thomas Manni <thomas.manni@free.fr> Date: Mon Nov 3 19:43:55 2014 +0100 operations: add gegl:color-exchange operations/common/Makefile.am | 1 + operations/common/color-exchange.c | 200 ++++++++++++++++++++++++ tests/compositions/Makefile.am | 1 + tests/compositions/color-exchange.xml | 18 +++ tests/compositions/reference/color-exchange.png | Bin 0 -> 192726 bytes 5 files changed, 220 insertions(+)
Seems to produce results identical to the GIMP plug-in, so i removed the plug-in and added your op instead, thanks :)