After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739850 - GClosure: add valgrind hints
GClosure: add valgrind hints
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-11-09 16:25 UTC by Allison Karlitskaya (desrt)
Modified: 2015-03-23 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GClosure: add valgrind hints (2.90 KB, patch)
2014-11-09 16:25 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2014-11-09 16:25:16 UTC 
GClosure has been in the "allocate area before the pointer" game since
before we did this with GTypeInstance.  At the time that this was done
for GClosure, we didn't have valgrind.h in GLib.

Now that we do, we should add similar valgrind hints as the ones we did
for GTypeInstance.  This substantially reduces reports of "possibly
lost" on pretty much any program that makes use of signals.
Comment 1 Allison Karlitskaya (desrt) 2014-11-09 16:25:18 UTC 
Created attachment 290279 [details] [review]
GClosure: add valgrind hints
Comment 2 Matthias Clasen 2014-11-10 03:54:58 UTC 
Review of attachment 290279 [details] [review]:

sounds like a good idea to me
Comment 3 Allison Karlitskaya (desrt) 2015-03-23 14:54:37 UTC 
Attachment 290279 [details] pushed as 69fd1fd - GClosure: add valgrind hints