GNOME Bugzilla – Bug 739573
gnome-shell does not process aspect ratio hints correctly as of 3.14.0
Last modified: 2015-06-22 15:20:04 UTC
As of 3.14.0 (and 3.14.1), gnome-shell does not process aspect ratio hints for applications properly. It appears that it is including the window decorations when computing sizes / aspect ratios for these hints, instead of managing the aspect ratio for the client area. This was working properly (for me) in 3.13.x, but broke as of 3.14.0. The most obvious failure mode is for media players setting an aspect ratio for video playback to avoid distortion and black bars. The key example that I see is https://github.com/mpv-player/mpv/issues/1191.
A quick grep through the source suggests that mutter is the one that does this aspect ratio enforcement and not gnome-shell, updating component accordingly.
Is there a simple testcase I can use to test what's going wrong here?
I'm not sure if this will help, but here is a picture I took of the issue if you wish to see it. https://i.imgur.com/FhHXDKv.jpg
Some testcases: Open gnome-terminal and press F11(enter fullscreen mode) repeatedly. The window will become smaller and smaller. Not only mpv but also mplayer/mplayer2 with most video out module has the same problem.
Fixed by https://git.gnome.org/browse/mutter/commit/?id=cb66ab5a87251b21c3f807474022a0b74dba8808
Thanks a lot. Seems like gnome-terminal's problem is caused by other reasons.
I'm still experiencing the problems described by Matthew with this patch (black bars in windowed mpv).
(In reply to comment #7) > I'm still experiencing the problems described by Matthew with this patch (black > bars in windowed mpv). From github (https://github.com/mpv-player/mpv/issues/1191#issuecomment-63251429): > My mistake! It seems that the patch isn't available in 3.14.2, which is the latest package version available in arch. I applied this patch atop Debian's 3.14.1-2 package, and the problem with mpv is mostly fixed, but the problem with gnome-terminal is not, as Ruei-Yual Lu noted. There is a remaining problem with mpv when starting fullscreen, but I'm not sure that's gnome/mutter's fault.
For gnome-terminal, see https://bugzilla.gnome.org/show_bug.cgi?id=740027 Try commit 286a6ad and the patch I attached.
The fix has landed on master, but not on the gnome-3-14 branch. For the sake of Fedora 21 users, please land it on the gnome-3-14 branch as well (currently I use a privately rebuilt mutter-3.14.2-1.fc21.x86_64 rpm package with this patch and the both patches from <https://bugzilla.gnome.org/show_bug.cgi?id=740027> which apply cleanly and solve the issues as advertised). Thanks!
(In reply to Ruei-Yuan Lu from comment #4) > Some testcases: > > Open gnome-terminal and press F11(enter fullscreen mode) repeatedly. The > window will become smaller and smaller. This appears to have regressed again in 3.16. Also the initial size of gnome-terminal is now always wrong for me at startup -- one character narrower and shorter than it is supposed to be. Created #751330