After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739374 - h264parse: sets srccaps too often
h264parse: sets srccaps too often
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.4.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-29 21:59 UTC by Matej Knopp
Modified: 2014-11-06 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.77 KB, patch)
2014-10-29 21:59 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2014-10-29 21:59:24 UTC 
Created attachment 289611 [details] [review]
Patch

srccaps should only be set when some other attributes besides codec_data are changing, however the comparison is currently broken as level and profile are missing from new caps, which always causes gst_caps_is_strictly_equal return FALSE
Comment 1 Sebastian Dröge (slomo) 2014-11-06 10:54:47 UTC 
commit df64862ebe7ef7fc0193320fbadf48450fe4f3fd
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Nov 6 11:53:04 2014 +0100

    h265parse: don't unnecesarily set src_caps
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739374

commit 1f367764fc261927b59b5d1dd4ee15e19eb15059
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Wed Oct 29 22:55:47 2014 +0100

    h264parse: don't unnecesarily set src_caps
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739374