After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738881 - Use GtkScrolledWindow::edge-overshot to load more elements
Use GtkScrolledWindow::edge-overshot to load more elements
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-20 17:06 UTC by Carlos Garnacho
Modified: 2015-01-13 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
view: Replace "Load more" button with edge hit detection (6.22 KB, patch)
2014-10-20 17:08 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2014-10-20 17:06:57 UTC 
I'm attaching a patch that uses the ::edge-overshot signal just added to GtkScrolledWindow in order to load more elements, and more gratifyingly, removes the "load more" button, not so needed anymore.
Comment 1 Carlos Garnacho 2014-10-20 17:08:00 UTC 
Created attachment 288969 [details] [review]
view: Replace "Load more" button with edge hit detection

If scrolling happens towards the bottom of the view, further elements
are loaded.
Comment 2 Cosimo Cecchi 2014-10-20 17:25:10 UTC 
Review of attachment 288969 [details] [review]:

Nice! Looks good to me.
Comment 3 Debarshi Ray 2014-10-20 18:00:33 UTC 
Is it not supposed to work when I am dragging using the handle?
Comment 4 Cosimo Cecchi 2014-12-22 07:25:19 UTC 
Further issues should probably be filed against GTK if it doesn't work under some circumstances. Closing this one as FIXED.
Comment 5 Cosimo Cecchi 2015-01-13 13:03:45 UTC 
See bug 742848