After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738869 - sound: Map the active input and output streams to their volume bars
sound: Map the active input and output streams to their volume bars
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sound
unspecified
Other All
: Normal normal
: ---
Assigned To: Control center sound maintainer(s)
Control-Center Maintainers
: 689493 741964 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-10-20 14:06 UTC by Rui Matos
Modified: 2015-04-01 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sound: Map the active input and output streams to their volume bars (2.43 KB, patch)
2014-10-20 14:06 UTC, Rui Matos 		rejected Details | Review

Description Rui Matos 2014-10-20 14:06:41 UTC 
This eliminates warnings like

(gnome-control-center:3225): sound-cc-panel-WARNING **: Unable to find
bar for stream alsa_output.pci-0000_00_1b.0.analog-stereo in
on_stream_volume_notify()

and makes the bars update when changing the volume through media keys
or the gnome-shell's volume slider.
Comment 1 Rui Matos 2014-10-20 14:06:44 UTC 
Created attachment 288948 [details] [review]
sound: Map the active input and output streams to their volume bars

The active input and output streams aren't added through add_stream()
so they weren't being mapped to their respective volume bars,
resulting in updates to the volume through other means not being
reflected in our UI.

Moving the mapping to bar_set_stream() which is called for every
stream fixes the problem. Also, there's no value in having a
helper function to do a g_hash_table_insert() and not doing the same
for the respective g_hash_table_remove()s so remove it.
Comment 2 Bastien Nocera 2014-10-21 07:54:19 UTC 
Review of attachment 288948 [details] [review]:

Looks good although the commit subject should reflect the user-facing changes, not explain the contents of the patch.
Comment 3 Rui Matos 2014-10-21 13:12:45 UTC 
Pushed with a different commit subject as suggested.
Comment 4 Bastien Nocera 2014-10-24 07:28:28 UTC 
*** Bug 689493 has been marked as a duplicate of this bug. ***
Comment 5 Bastien Nocera 2015-03-17 11:23:03 UTC 
This caused bug 746227
Comment 6 Bastien Nocera 2015-03-17 11:23:38 UTC 
commit 5e7c1544fd12739d4da80cf0d6b2680f9d4b16d6
Author: Bastien Nocera <hadess@hadess.net>
Date:   Tue Mar 17 12:15:42 2015 +0100

    sound: Fix output/output bars not following external changes
    
    When looking up a bar for a particular stream, special-case the input
    and output bars/streams, as they will not be added to the "bars"
    hashtable (which is, as per comment, only for applications and the sound
    events bar).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738869
Comment 7 Bastien Nocera 2015-04-01 12:00:14 UTC 
*** Bug 741964 has been marked as a duplicate of this bug. ***