After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738860 - GtkPaned: Add a "wide-handle" property
GtkPaned: Add a "wide-handle" property
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-10-20 11:40 UTC by Matthias Clasen
Modified: 2014-10-20 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GtkPaned: Add a "wide-handle" property (5.90 KB, patch)
2014-10-20 11:40 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2014-10-20 11:40:02 UTC
This can be used by applications to indicate that a paned is expected
to be actively used by the users for configuring the UI, and needs
a prominent handle.
Comment 1 Matthias Clasen 2014-10-20 11:40:05 UTC
Created attachment 288919 [details] [review]
GtkPaned: Add a "wide-handle" property
Comment 2 Lapo Calamandrei 2014-10-20 12:12:07 UTC
It defaults to false, which is good
Comment 3 Carlos Garnacho 2014-10-20 12:17:36 UTC
It makes sense to me on certain UIs. My only concern would be about mixing this API with manual add/remove of the "wide"class, but it should only affect for notify::wide-handle purposes AFAICS. This seems like minor punishment for misuse, so definitely not a big concern.

Semi-seriously, we maybe should bind boolean properties to css classes more generically, and call that the new "style properties". Nowadays I'd think there's more apps than themes trying to tweak those...
Comment 4 Matthias Clasen 2014-10-20 12:46:05 UTC
(In reply to comment #3)
> It makes sense to me on certain UIs. My only concern would be about mixing this
> API with manual add/remove of the "wide"class, but it should only affect for
> notify::wide-handle purposes AFAICS. This seems like minor punishment for
> misuse, so definitely not a big concern.
> 
> Semi-seriously, we maybe should bind boolean properties to css classes more
> generically, and call that the new "style properties". Nowadays I'd think
> there's more apps than themes trying to tweak those...

What I (and Benjamin, I think) have been going with for a while is:

Manual adding of style classes is 'choose your own adventure, keep all the pieces' territory. For every supported use of a style class, there should be widget api to set it. In most cases, that will be a boolean property. Compare
what I've recently done to the various shadow-type properties.
Comment 5 Matthias Clasen 2014-10-20 12:51:11 UTC
Attachment 288919 [details] pushed as cf0c9eb - GtkPaned: Add a "wide-handle" property