GNOME Bugzilla – Bug 738800
Menu border missing in Adwaita when no compositor is running
Last modified: 2014-11-03 03:09:20 UTC
As of GTK/Adwaita 3.14, all menu panes (context menu, pull-down menu, etc.) are missing a border around the pane, so that the menu blends directly into white backgrounds below. I have noticed that this issue disappears when a compositor is being run.
Created attachment 288841 [details] Screenshot
True, we want to use a shadow istead of border in a composited env since it gives better results, we should treat the other case with a border, not sure I have a way to do that by the theme btw
I believe when I added the csd support in menus, the differentiation between .window-frame.csd.popup and .window-frame.popup worked for this.
Border doesn't seem to work there tho :-/ try .window-frame.popup { border: 1px solid red; } within the inspector, even combining it with .menu doesn't seem to work
Created attachment 289166 [details] [review] adds border in a non composited env This should fix that, I have no ways to try it atm, can you guys confirm it works right? It's against master, but I it should apply to 3.14 as well
Created attachment 289185 [details] screenshot with metacity
Created attachment 289198 [details] [review] Second attempt Let's try resetting the shadow
Created attachment 289199 [details] screenshot with openbox
Tobias, what window manager is your screenshot taken with ?
I guess this is a general problem, since we're using shadows as borders in an enviroment where we can control them (Gnome), anywhere else we don't know, thinking about other platforms too, hence I guess we need a proper solution. Any idea Benjamin?
Wasn't the idea that we draw shadows ourselves on menus just like we do on regular windows?
(In reply to comment #11) > Wasn't the idea that we draw shadows ourselves on menus just like we do on > regular windows? the problem is one of control and communication - some compositors decide to draw shadows on menus themselves (metacity is an example), and some even expose this in their user preferences (kwin, I believe). Hard to make anything that works everywhere, with this much variation.
(In reply to comment #9) > Tobias, what window manager is your screenshot taken with ? This was on Qtile. I’m not seeing the borders in any WM, though, unless an additional compositor is running. I just tried it with dwm and twm to be certain.