After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738761 - Add context menu
Add context menu
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.15.x
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-18 13:37 UTC by Zeeshan Ali
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Zeeshan Ali 2014-10-18 13:37:42 UTC
According to the new mockups, we should be showing a context menu on right-click on a box thumbnail:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/boxes/wires/multi-window.png

Note: we need to make sure menu is popable through the context menu button found on many keyboards.
Comment 1 Zeeshan Ali 2014-11-12 17:53:57 UTC
And a menubutton with the same menu needs to replace the properties button in display mode:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/boxes/wires/properties-modal.png
Comment 2 Zeeshan Ali 2014-11-14 17:45:46 UTC
Pushed the patches that add such a context menu.

commit: a8df0ac834429b76fc0689aa9060d2b25ac187fc

    app-window: show_properties() take current_item into account
    
    If we already have an item marked as current, simply go directly to
    properties view, ignoring selection.
    
commit: 3fdbfde5cd2128b4a189fe10058ebd23713bfaf6

    app: Make open_in_new_window() public
    
commit: adf7a15f09c1fd8bbc7a2086abf0636a4f71a0a0

    app: Make delete_machines_undoable.message, optional
    
    Make message arg of delete_machines_undoable method, nullable and
    optional.

commit: 1b1e0a704fb0884c7753c1c7853fa59a06e4c735

    Add ActionsPopover
    
    Add a popover to present a item-specific actions menu that includes:

   * Open in new window
    * Favorite
    * Pause
    * Delete
    * Properties
    
commit: 1328371f7ef56ea51a08f47e29adf025405c0dfd

    collection-view: Disallow selection_mode from the view
    
    If the view is requesting selection mode, it means user has clicked
    right-mouse button and we now want to show a context menu on
    right-click.
    
commit: 8d1086709a0ab6b938cc051e6c0dfd55c591279f

    collection-view: Show context menu on right-click
    
    Show ActionsPopover when user right clicks on an item.

commit: 67de3436b18b0e7e8c53c24102e9b553606c982b

    collection-view: Show context menu on menu key

    Show ActionsPopover when user presses menu key when keyboard cursor is
    on an item.