GNOME Bugzilla – Bug 738751
libxml2-2.9.2: use pkgconfig to detect icu
Last modified: 2021-07-05 13:25:35 UTC
Created attachment 288798 [details] [review] 1.patch We are applying this patch in Gentoo since some time to rely on pkgconfig for icu detection (that is useful for us for handling our multilib support https://bugs.gentoo.org/show_bug.cgi?id=480404 ), maybe the patch would also be interesting for you and could be upstreamed :)
Thanks, as-is no, I don't want libxml2 to pick up libicu by default. Libxml2 uses iconv, already coming with libc to do encoding conversion and libicu is bigger in size than libxml2. I see no reason to compile with ICU support on Linux, and really don't see why your GNOME team needs it either. That said using pkgconfig in case where --with-icu is requested at configure time, yes that would be a good patch, but not to pick it up by default. Daniel
Well, the patch doesn't change the default, all the detection will be skipped if: if test "$with_icu" != "yes" ; then echo Disabling ICU support else as done previously. Regarding the default, in our case people is able to disable/enable icu regarding their USE flags setting... then, it's a bit up to the user :)
Okay, I misread. libxml2 need to be able to compile on machines without pkgconfig (yes, yes :) and the fallback to calling icu-config should be preserved if pkgconfig doesn't work. See other places on configure.ac doing such a fallback :) thanks, Daniel
Created attachment 288801 [details] [review] 1.patch This one looks to work fine for me :)
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/libxml2/-/issues/ Thank you for your understanding and your help.