GNOME Bugzilla – Bug 738720
Private browsing leaves data in localstorage
Last modified: 2014-11-25 13:30:22 UTC
Reproduce: 1) Open a incognito window 2) Visit a website 3) File appears in ~/.local/share/webkitgtk/localstorage/ 4) Exit application 5) Data remains in ~/.local/share/webkitgtk/localstorage/ Private browsing should purge all related data on exit
See https://bugs.webkit.org/show_bug.cgi?id=138828
Created attachment 291352 [details] [review] Do not use the default WebKitWebContext
Created attachment 291353 [details] [review] embed: Use a custom local storage directory for epiphany
I have disabled the prefetch DNS in location-entry for now, since it's at the wrong place, and this is more important.
Created attachment 291354 [details] [review] Do not use the default WebKitWebContext Removed a workaround that is no longer needed and I forgot to remove.
Review of attachment 291354 [details] [review]: Don't forget to bump the minimum WebKit version ::: embed/ephy-web-view.c @@ +2193,3 @@ ephy_web_view_new_with_related_view (WebKitWebView *related_view) { + EphyEmbedShell *shell = ephy_embed_shell_get_default (); You don't need this one here! ::: lib/widgets/ephy-location-entry.c @@ +38,3 @@ #include <string.h> +#if 0 +/* FIXME: Refactor the DNS prefetch, this is a layering violation */ Huh, didn't realize we were doing this. I wonder where would be a good place to handle this if not the location entry....
(In reply to comment #6) > Review of attachment 291354 [details] [review]: > > Don't forget to bump the minimum WebKit version Just kidding.
(In reply to comment #6) > Review of attachment 291354 [details] [review]: > > Don't forget to bump the minimum WebKit version Already did it in master. > ::: embed/ephy-web-view.c > @@ +2193,3 @@ > ephy_web_view_new_with_related_view (WebKitWebView *related_view) > { > + EphyEmbedShell *shell = ephy_embed_shell_get_default (); > > You don't need this one here! Right, forgot to remove this too when removed the workaround. Thanks! > ::: lib/widgets/ephy-location-entry.c > @@ +38,3 @@ > #include <string.h> > +#if 0 > +/* FIXME: Refactor the DNS prefetch, this is a layering violation */ > > Huh, didn't realize we were doing this. I wonder where would be a good place to > handle this if not the location entry.... lib/widgets don't know anything about embed, the location entry could emit a signal notifying that an element in the completion list has been hovered, for example. But I even doubt that doing a DNS prefetch of the elements hovered in the completion list is that useful.