After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738698 - Add "ostree remote delete" and corresponding API
Add "ostree remote delete" and corresponding API
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-17 16:10 UTC by Colin Walters
Modified: 2014-10-17 23:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add "ostree remote delete" and corresponding API (5.07 KB, patch)
2014-10-17 16:10 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2014-10-17 16:10:40 UTC 
For Anaconda, we have an ugly bootstrapping problem where we need to
add the remote to the repository's config, then do a pull+deploy, then
remove and re-add the config, because /etc/ostree/remotes.d doesn't
exist yet in the target system.
Comment 1 Colin Walters 2014-10-17 16:10:41 UTC 
Created attachment 288769 [details] [review]
Add "ostree remote delete" and corresponding API
Comment 2 Matthew Barnes 2014-10-17 16:25:40 UTC 
Review of attachment 288769 [details] [review]:

Patch looks alright to me.

My only nit is there's no point passing a GError to g_key_file_to_data() -- especially if you're not checking for error (bad evo memories...), but the docs say it's safe not to.
Comment 3 Colin Walters 2014-10-17 23:10:11 UTC 
Fixed up the error usage, thanks!

Attachment 288769 [details] pushed as cdfcf09 - Add "ostree remote delete" and corresponding API