After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738567 - Suspend and unsuspend call consistency
Suspend and unsuspend call consistency
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
1.4.3
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-15 08:59 UTC by Srimanta Panda (trollkarlen)
Modified: 2018-01-13 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for suspend and unsuspend (1.95 KB, patch)
2014-10-30 11:15 UTC, Srimanta Panda (trollkarlen) 		none Details | Review

Description Srimanta Panda (trollkarlen) 2014-10-15 08:59:13 UTC 
Consistent behavior during play and pause

Currently gst_rtsp_media_suspend() and gst_rtsp_media_unsuspend() methods are called in a inconsistent way during the pause and play request.

Suspend method is called inside media_set_pipeline_state_locked() while pause and unsuspend is called during handle_play_request().

In a good design perspective, suspend should be called during the handle_pause_request() after setting the state and unsuspend should be called in the beginning of the play before setting the state.
Comment 1 Srimanta Panda (trollkarlen) 2014-10-15 08:59:34 UTC 
I am working on this issue already.
Comment 2 Srimanta Panda (trollkarlen) 2014-10-30 11:15:57 UTC 
Created attachment 289643 [details] [review]
patch for suspend and unsuspend
Comment 3 Tim-Philipp Müller 2018-01-13 14:33:42 UTC 
Sorry no one ever reviewed this.

The code has changed quite a lot since then and this logic has moved elsewhere.

If it's still something that should be changed in the current implementation, please re-open and make a new patch against master, thanks!