After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738531 - bootstrap: Install flex on OS X
bootstrap: Install flex on OS X
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-14 14:09 UTC by Nirbheek Chauhan
Modified: 2014-10-21 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a recipe for flex (899 bytes, patch)
2014-10-14 14:09 UTC, Nirbheek Chauhan
committed Details | Review
Add flex to OS X bootstrap (991 bytes, patch)
2014-10-14 14:10 UTC, Nirbheek Chauhan
accepted-commit_now Details | Review
Add flex and bison to OS X and Windows (1.08 KB, patch)
2014-10-15 14:08 UTC, Nirbheek Chauhan
committed Details | Review

Description Nirbheek Chauhan 2014-10-14 14:09:55 UTC
Created attachment 288518 [details] [review]
Add a recipe for flex

Add a build-tools recipe for flex and add it to OS X bootstrap; it's already installed during Linux bootstrap.
Comment 1 Nirbheek Chauhan 2014-10-14 14:10:13 UTC
Created attachment 288519 [details] [review]
Add flex to OS X bootstrap
Comment 2 Sebastian Dröge (slomo) 2014-10-14 14:11:54 UTC
Comment on attachment 288519 [details] [review]
Add flex to OS X bootstrap

it should probably also be added for Windows bootstrap
Comment 3 Nirbheek Chauhan 2014-10-14 14:17:36 UTC
(In reply to comment #2)
> (From update of attachment 288519 [details] [review])
> it should probably also be added for Windows bootstrap

I didn't add it there because bison wasn't, and those two usually go together. Maybe both should be added?
Comment 4 Sebastian Dröge (slomo) 2014-10-14 14:20:16 UTC
Yes, alternatively we could also just build them ourselves on all platforms instead of using the distro versions on Linux. Like we do for other build tools already
Comment 5 Nirbheek Chauhan 2014-10-15 14:08:29 UTC
Created attachment 288590 [details] [review]
Add flex and bison to OS X and Windows

(In reply to comment #4)
> Yes, alternatively we could also just build them ourselves on all platforms
> instead of using the distro versions on Linux. Like we do for other build tools
> already

I think this would extend to gettext, pkg-config, yasm, etc as well (maybe more?). Do we also remove these from build/bootstrap/linux.py? Feels like a larger question.

The attached patch adds bison + flex to Windows as well.
Comment 6 Sebastian Dröge (slomo) 2014-10-21 09:47:14 UTC
Yes, can you create another patch for that in another bug? :)

commit 772e328639edd957d90b22e21730c229b4f9551a
Author: Nirbheek Chauhan <nirbheek@centricular.com>
Date:   Wed Oct 8 05:07:09 2014 +0530

    flex: Add a build-tools recipe for flex

commit 2fff1338bd14a9f517fce3cf99e271c61b8656da
Author: Nirbheek Chauhan <nirbheek@centricular.com>
Date:   Tue Oct 14 16:37:14 2014 +0530

    bootstrap: Add bison, flex to OS X and Windows bootstrap
    
    Linux installs flex and bison, OS X and Windows should also
Comment 7 Nirbheek Chauhan 2014-10-21 10:12:30 UTC
(In reply to comment #6)
> Yes, can you create another patch for that in another bug? :)
> 

bug 738916

Haven't posted a patch yet because I would need to test that bootstrap works without any of those tools installed in the system prefix.