After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738474 - [regression] With Adwaita / GTK+ 3.14, vertical inline toolbars styling is broken
[regression] With Adwaita / GTK+ 3.14, vertical inline toolbars styling is br...
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Themes
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 682886
 
 
Reported: 2014-10-13 18:16 UTC by Jean-François Fortin Tam
Modified: 2018-04-15 00:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (15.97 KB, image/png)
2014-10-13 18:16 UTC, Jean-François Fortin Tam 		Details

Description Jean-François Fortin Tam 2014-10-13 18:16:53 UTC 
Created attachment 288412 [details]
screenshot

As the attached screenshot demonstrates, inline toolbars have an incorrect style when oriented vertically. This used to work in earlier GTK releases, as you can see on this screenshot taken with 3.12: http://www.pitivi.org/i/screenshots/archive/0.94.png (or the older http://www.pitivi.org/i/screenshots/archive/0.91.png)
Comment 1 Emmanuele Bassi (:ebassi) 2014-10-13 18:30:42 UTC 
adding Lapo to CC.
Comment 2 Lapo Calamandrei 2014-10-13 19:20:59 UTC 
Vertical inline toolbars are not styled, but vertically linking buttons should work, I'll check that out.
Comment 3 Lapo Calamandrei 2014-10-13 21:08:09 UTC 
Jean-François I tried to have a look, but F21 packaged version doesn't work and the git version built via jhbuild shouts me an the following error:

Traceback (most recent call last):

+ Trace 234219

  • File "/home/lapo/jhbuild/install/bin/pitivi", line 139 in <module> 
    _run_pitivi()
  • File "/home/lapo/jhbuild/install/bin/pitivi", line 124 in _run_pitivi 
    from pitivi import application
  • File "/home/lapo/jhbuild/install/lib/pitivi/python/pitivi/application.py", line 31 in <module> 
    from pitivi.effects import EffectsManager
  • File "/home/lapo/jhbuild/install/lib/pitivi/python/pitivi/effects.py", line 54 in <module> 
    from pitivi.utils.ui import EFFECT_TARGET_ENTRY, SPACING
  • File "/home/lapo/jhbuild/install/lib/pitivi/python/pitivi/utils/ui.py", line 404 in <module> 
    (_("%d fps") % 12, Gst.Fraction(12.0, 1.0)),
TypeError: object() takes no parameters 






Comment 4


Jean-François Fortin Tam





          2014-10-13 21:27:02 UTC
        



Hi folks, does gnome's jhbuild include/build gst-python? It's needed because introspection can't deal with everything; see also http://wiki.pitivi.org/wiki/Dependencies

And yeah, the packaged (0.93) version is broken in Fedora 21 due to bug #735529 (fixed for the next release).






Comment 5


Lapo Calamandrei





          2014-10-14 07:57:40 UTC
        



I'm pretty sure I have gst-python built via jhbuild






Comment 6


Matthias Clasen





          2014-10-14 13:31:00 UTC
        



lets get a vertical inline toolbar example into widget-factory, maybe ?






Comment 7


Lapo Calamandrei





          2014-10-14 17:05:54 UTC
        



It's not really a pattern I'd like to have used around, I implemented that in the old adwaita just for pitivi basically.






Comment 8


Matthias Clasen





          2014-10-14 17:41:36 UTC
        



there's more things in widget-factory that we probably don't want to have 'used around', but still want to keep working, theme-wise.






Comment 9


Lapo Calamandrei





          2014-10-15 09:51:45 UTC
        



Sure, I think this is one of the cases (not sure yet since pitivi is not working for me) where the inline toolbar is built with GtkToolItems with buttons inside which greatly messes up the scss code, I'd have no problems having vertical inlines made of GtkToolButtons btw.






Comment 10


Matthias Clasen





          2014-10-16 02:05:57 UTC
        



I've added some vertical examples to the widget factory






Comment 11


Matthias Clasen





          2014-10-19 20:46:18 UTC
        



I think this can be closed now ?






Comment 12


Alex Băluț





          2015-11-01 11:24:58 UTC
        



Pitivi's vertical toolbar is composed of GtkToolButtons, but still looks bad. The buttons are missing the right edge in Adwaita. Please reopen the bug.






Comment 13


Alex Băluț





          2015-11-01 11:37:02 UTC
        



You can notice the problem in widget-factory if you add "inline-toolbar" to Style Classes for the vertical GtkToolbar on the 3rd page.






Comment 14


Thibault Saunier





          2015-11-03 12:56:37 UTC
        



Reopenning as asked by Alex.






Comment 15


Matthias Clasen





          2018-02-10 05:06:52 UTC
        



We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.






Comment 16


Matthias Clasen





          2018-04-15 00:28:17 UTC
        



As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla.

If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab:

https://gitlab.gnome.org/GNOME/gtk/issues/new