GNOME Bugzilla – Bug 738260
Allow customisation of the login prompt (both in gdm and in screen-shield)
Last modified: 2018-10-19 15:11:43 UTC
This is a change to allow the customisation of the background shown on the login prompts. This is a follow up to a throw-away patch that was written by Ray Strode at my request during the Mageia 4 release cycle to allow us to customise things a little and provide some branding. Recent changes in gnome-shell background handling meant that that patch no longer worked, so I took the opportunity to tidy it up and write it properly. OOTB, the look+feel should be retained to what it is currently, but a few simple schema overrides (or user customisations) and you can tailor it to taste! Patches (to gnome-shell and gsettings-desktop-schemas) to follow.
Created attachment 288170 [details] [review] gnome-shell part of the patch
Created attachment 288172 [details] [review] gsettings-desktop-schemas part.
Why do we need a separate schema for gdm? gdm has its own user, and thus we should be able to make changes to the background directly to the gdm user. Isn't that right?
(In reply to comment #3) > Why do we need a separate schema for gdm? gdm has its own user, and thus we > should be able to make changes to the background directly to the gdm user. > Isn't that right? Hmmm, so you mean that the "desktop" background can be the schema used for the password-entry screen as that's gdm's equiv of a "desktop"? i.e. just change: const LOGIN_SCHEMA = 'org.gnome.desktop.background.login'; to const LOGIN_SCHEMA = 'org.gnome.desktop.background'; and then set up the desired customisation for the gdm user only? In principle that's OK for the initial login screen, but does that also apply to the screen shield unlock screen after a user has logged in? I thought those preferences were taken from the current user? If so, then we would still need separate schemas otherwise the users desktop background would leak to the password entry screen.
(In reply to comment #3) > Why do we need a separate schema for gdm? gdm has its own user, and thus we > should be able to make changes to the background directly to the gdm user. > Isn't that right? How does this work? It would be great to have a system wide gsettings service to set system wide settings that work as default fallbacks in case the user setting is set to the default value but no such service exists currently. I also don't see how this patch helps the gdm session given that you are not able to modify the gdm user's setting from a regular user session.
Created attachment 294452 [details] [review] Another patch, this time for gnome-tweak-tool to allow users to customise this Another patch (because even tho' we have traditionally customised this as a distro for years, I got sick of our distro default for my user account. Still kept the defaults for actual login tho' (gdm user) - this is just for unlock (my user)) Also adding this to gently prod Ray to review it (even tho' he doesn't like the idea generally, I feel I have the general principle on my side! Go on Ray... you know you like this idea really... :p)
(In reply to comment #5) > (In reply to comment #3) > > Why do we need a separate schema for gdm? gdm has its own user, and thus we > > should be able to make changes to the background directly to the gdm user. > > Isn't that right? > > How does this work? It would be great to have a system wide gsettings service > to set system wide settings that work as default fallbacks in case the user > setting is set to the default value but no such service exists currently. You can provide overrides for this (typically in distro theme packages) in the form of ini-like files e.g.: /usr/share/glib-2.0/schemas/glib2-branding.gschema.override This then sets the default values for all users. > I also don't see how this patch helps the gdm session given that you are not > able to modify the gdm user's setting from a regular user session. It doesn't help the gdm session, only your own user (or the defaults - which gdm also uses - if you provide a gschema.override as mentioned above.
Not sure we want customization of the system background, but let's ask the design team ...
*** Bug 751359 has been marked as a duplicate of this bug. ***
Olav tells me the patch no longer applies, so I'll look at rediffing it shortly.
Same for the gsettings-desktop-schemas one, but that I was able to rediff; just take it from Cauldron (and verify:-P)
Created attachment 321467 [details] [review] gnome-shell part of the patch
Created attachment 321468 [details] [review] gsettings-desktop-schemas part.
OK, so my definition of "shortly" was sadly about seven months! Took me that long to get up and running with latest Gnome again. Sorry for the delay. Rediff was actually pretty much automatic (git did it all). Running here fine as before. Please consider this as an upstreamable option. The code is relatively minimal (and I'd be happy to do a second patch to rename variables as I admit it can be a little confusing if that helps grease the wheels).
*** Bug 695662 has been marked as a duplicate of this bug. ***
I filed an issue to track this bug: https://gitlab.gnome.org/GNOME/gnome-shell/issues/680
Closing this task as it has been moved to https://gitlab.gnome.org/GNOME/gnome-shell/issues/680 which has a patch attached.