GNOME Bugzilla – Bug 738244
qtdemux: add support for vorbis in MP4
Last modified: 2018-03-22 14:27:05 UTC
Created attachment 288144 [details] [review] Patch Apparently people mux vorbis in MP4 for some reason Sample video: https://s3.amazonaws.com/MatejK/Samples/Elektrolux%20UltraScilencer%20Green%20%E2%80%93%20Dammsugaren%20med%200%20markfriga%CC%8Ang.mp4
Created attachment 368306 [details] [review] qtdemux: Handle variant of vorbis in mp4 Comes from gpac apparently. The codec_data uses the same packing mechanism as matroska.
Review of attachment 368306 [details] [review]: ::: gst/isomp4/qtdemux.c @@ +13314,3 @@ + guint *length, last; + + GST_MEMDUMP ("xiph codec data", codec_data, codec_data_size); Please parse the demuxer in here and use GST_MEMDUMP_OBJECT(), etc :)
Created attachment 368317 [details] [review] qtdemux: Handle variant of vorbis in mp4 Comes from gpac apparently. The codec_data uses the same packing mechanism as matroska.
How is your patch different from Matej's in comment 0 though?
I hadn't even noticed Matej had put a patch initally, I only saw the link to the buggy file *facepalm*. Anyway, it seems we both took the code from matroska-demux. I also added more checks for sizes and to be 100% sure it's really vorbis (and not something else using 0xDD which is a reserved type).
commit d7038b9bb0d53e98f55a7df851223dd6aa117c0f (HEAD -> master, origin/master, origin/HEAD) Author: Edward Hervey <edward@centricular.com> Date: Tue Feb 13 11:50:05 2018 +0100 qtdemux: Handle variant of vorbis in mp4 Comes from gpac apparently. The codec_data uses the same packing mechanism as matroska. https://bugzilla.gnome.org/show_bug.cgi?id=738244