After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737892 - openh264: update to latest openh264 release and use pkg-config
openh264: update to latest openh264 release and use pkg-config
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-04 17:42 UTC by Nicola
Modified: 2015-01-14 11:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Nicola 2014-10-04 17:42:05 UTC
I installed openh264 in gst-uninstalled prefix, running configure on -bad, does not detect the library, if I link the library from uninstalled prefix in /usr/include and /usr/lib openh264 plugin are built correctly
Comment 1 Sebastian Dröge (slomo) 2014-10-04 18:26:21 UTC
That's because the uninstalled prefix is not placed into CPPFLAGS/CFLAGS/LDFLAGS/CXXFLAGS by gst-uninstalled.
Comment 2 Nicola 2014-10-23 08:08:44 UTC
Thanks for the suggestion I tryed to set include path and lib path as you suggested with no success, for now I'll use the symlink, however any other library in the uninstalled prefix is used with no issue (glib,pango ecc..)
Comment 3 Nicola 2014-10-23 11:46:36 UTC
even if -bad configure does not find openh264 if I add this line:

OPENH264_LIBS = -lopenh264

to ext/openh264/Makefile

the plugin is builded and it works, 

can this be a bug if the configure?
Comment 4 Tim-Philipp Müller 2015-01-13 09:30:43 UTC
It should work once we use newer openh264 releases which provide a pkg-config file.

Zaheer was working on that.
Comment 5 Zaheer Abbas Merali 2015-01-13 18:26:49 UTC
I'm working on it. If you want a stop gap, use this commit:

http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=15394aa70543f55c54fa8a474805224f4138f76c
Comment 6 Nicola 2015-01-14 07:33:35 UTC
it works fine with git master and openh264 1.3.1
Comment 7 Edward Hervey 2015-01-14 08:33:44 UTC
For some reason, bumping to openh264 1.3.1 makes the ios builds fail (openh264 builds fine, but it's no longer detected by -bad's configure):

https://ci.gstreamer.net/job/cerbero-ios-universal-7.1/1582/console
Comment 8 Sebastian Dröge (slomo) 2015-01-14 09:58:15 UTC
Should be fixed now:
http://cgit.freedesktop.org/gstreamer/cerbero/commit/?id=90b419b632cd9493e352e15327ab683d73966c40