After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737888 - Properly watch the child process state
Properly watch the child process state
Status: RESOLVED OBSOLETE
Product: brasero
Classification: Applications
Component: general
git master
Other Linux
: Normal major
: ---
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-04 15:29 UTC by Laurent Bigonville
Modified: 2018-09-21 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
child-waiting-error-handling.patch (2.23 KB, patch)
2014-10-04 15:29 UTC, Laurent Bigonville 		none Details | Review

Description Laurent Bigonville 2014-10-04 15:29:41 UTC 
Created attachment 287715 [details] [review]
child-waiting-error-handling.patch

Hi,

This bug has been reported on the Debian BTS:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=681694

====8<====
Dear Maintainer,

Please consider answering these questions, where appropriate ***

In libbrasero-burn/burn-process.c:brasero_process_watch_child (gpointer data)

waitpid() could have returned positive value (child's pid) due to the
child's change of state, e.g. child being signalled for any (obscure)
reason (SIGPIPE, SIGSTOP, etc), and also child's exit status is being
blindly "examined" by flat WEXITSTATUS(status), instead of first checking
WIFEXITED(status) for returning true, i.e. that the child has actually exited.

This could lead to unnoticed problem with the child process state. For 
instance, I think the log message [1] of "process finished with status
0" could be pretty much bogus in this particular case shown in the log with
a burn failure halfway around ~49-50%. (see the tail of waitpid(2) for a good
example of a diligent parent waiting for their possibly naughty child)

[1] https://launchpadlibrarian.net/71440716/brasero_log.txt
====8<====
Comment 1 GNOME Infrastructure Team 2018-09-21 17:47:54 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/brasero/issues/274.