After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737795 - [review] dcbw/wifi-band-fixes: fix sending band to the supplicant and add ifcfg-rh support
[review] dcbw/wifi-band-fixes: fix sending band to the supplicant and add ifc...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: Wi-Fi
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-02 17:28 UTC by Dan Williams
Modified: 2014-10-11 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Dan Williams 2014-10-02 17:28:17 UTC 
NM encoded the freq_list parameter in the wrong way.  Also add ifcfg-rh support for wifi bands.
Comment 1 Thomas Haller 2014-10-07 13:09:38 UTC 
The reader accepts contradicting BAND/CHANNEL setting. That could be fine, but we could also error out when user sets a CHANNEL that mismatches the BAND. I dunno.

All LGTM.
Comment 2 Dan Williams 2014-10-08 15:17:12 UTC 
Ok, fixed up to validate band vs. channel.  Repushed with two more testcases for that too.
Comment 3 Thomas Haller 2014-10-08 16:54:38 UTC 
LGTM
Comment 4 Dan Williams 2014-10-09 03:16:01 UTC 
Pushed to master and 0.9.10