After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737724 - vc1parse: unref caps when it is empty in renegotiate()
vc1parse: unref caps when it is empty in renegotiate()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal minor
: 1.4.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-01 14:27 UTC by Aurélien Zanelli
Modified: 2014-10-14 07:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vc1parse: unref caps when it is empty in renegotiate() (881 bytes, patch)
2014-10-01 14:28 UTC, Aurélien Zanelli
committed Details | Review

Description Aurélien Zanelli 2014-10-01 14:27:20 UTC
In gst_vc1_parse_renegotiate(), when allowed_caps is empty, we return FALSE without unref it.
Comment 1 Aurélien Zanelli 2014-10-01 14:28:14 UTC
Created attachment 287520 [details] [review]
vc1parse: unref caps when it is empty in renegotiate()
Comment 2 Sebastian Dröge (slomo) 2014-10-02 07:44:09 UTC
commit 677d052e842ea38886330046f7c77620ea5bb1eb
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Wed Oct 1 16:19:02 2014 +0200

    vc1parse: unref caps when it is empty in renegotiate()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737724