After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737649 - validate-runner: cleanup.
validate-runner: cleanup.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
unspecified
Other All
: Normal normal
: 1.4.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-30 08:42 UTC by Mathieu Duponchelle
Modified: 2014-09-30 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst-validate-runner: Add locking for the reports list. (3.49 KB, patch)
2014-09-30 08:42 UTC, Mathieu Duponchelle 		accepted-commit_now Details | Review
validate-runner: Hide implementation. (8.86 KB, patch)
2014-09-30 08:42 UTC, Mathieu Duponchelle 		accepted-commit_now Details | Review
validate-runner: switch to using a GList for the reports. (9.68 KB, patch)
2014-09-30 08:42 UTC, Mathieu Duponchelle 		accepted-commit_now Details | Review

Description Mathieu Duponchelle 2014-09-30 08:42:16 UTC 
Implements various FIXMES, thread safety and stop using a GSList.
Comment 1 Mathieu Duponchelle 2014-09-30 08:42:18 UTC 
Created attachment 287427 [details] [review]
gst-validate-runner: Add locking for the reports list.
Comment 2 Mathieu Duponchelle 2014-09-30 08:42:22 UTC 
Created attachment 287428 [details] [review]
validate-runner: Hide implementation.
Comment 3 Mathieu Duponchelle 2014-09-30 08:42:25 UTC 
Created attachment 287429 [details] [review]
validate-runner: switch to using a GList for the reports.

+ Return a copy of that list in get_reports.
+ update tests.
Comment 4 Thibault Saunier 2014-09-30 08:57:31 UTC 
Review of attachment 287427 [details] [review]:

Looks good!
Comment 5 Thibault Saunier 2014-09-30 09:12:44 UTC 
Review of attachment 287427 [details] [review]:

Actually you should make sure our testsuite (gst-validate-launcher one) still passes and push it before 1.4, should be good.
Comment 6 Thibault Saunier 2014-09-30 09:13:57 UTC 
Review of attachment 287428 [details] [review]:

Looks good, you should just make sure the testsuite pass and push.
Comment 7 Thibault Saunier 2014-09-30 09:14:16 UTC 
Review of attachment 287429 [details] [review]:

OK
Comment 8 Mathieu Duponchelle 2014-09-30 09:44:05 UTC 
The test suite passes, pushed :

commit 8cfffb4a3acfb79ca60bdd397eb52e1595fab104
Author: Mathieu Duponchelle <mathieu.duponchelle@collabora.com>
Date:   Tue Sep 30 10:30:24 2014 +0200

    validate-runner: switch to using a GList for the reports.
    
    + Return a copy of that list in get_reports.
    + update tests.

commit 1f1cf83af80a03088aca9e56d44d383fc268834b
Author: Mathieu Duponchelle <mathieu.duponchelle@collabora.com>
Date:   Tue Sep 30 09:24:48 2014 +0200

    validate-runner: Hide implementation.

commit 855f14145348bce32f38725a100c69b375466274
Author: Mathieu Duponchelle <mathieu.duponchelle@collabora.com>
Date:   Tue Sep 30 09:11:58 2014 +0200

    gst-validate-runner: Add locking for the reports list.