After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737369 - solaris build fix
solaris build fix
Status: RESOLVED OBSOLETE
Product: gnome-desktop
Classification: Core
Component: general
git master
Other Solaris
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-25 14:53 UTC by Patrick Welche
Modified: 2015-08-03 16:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
solaris build fix (1.58 KB, patch)
2014-09-25 14:55 UTC, Patrick Welche 		needs-work Details | Review
more readable fix (1.37 KB, patch)
2014-10-01 11:18 UTC, Patrick Welche 		none Details | Review

Description Patrick Welche 2014-09-25 14:53:15 UTC 
Solaris doesn't have an equivalent of O_DIRECTORY, so only use it if it is defined. Amusingly this bug seems to have been predicted by the comment:

   /* Linux specific probably */

The O_DIRECTORY build failure was encountered in libgnome-desktop/libgsystem/gsystem-file-utils.c, but "fixing" the other occurence just in case.
Comment 1 Patrick Welche 2014-09-25 14:55:48 UTC 
Created attachment 287085 [details] [review]
solaris build fix
Comment 2 Bastien Nocera 2014-09-26 09:44:54 UTC 
Review of attachment 287085 [details] [review]:

Isn't this easier to read?
#ifndef O_DIRECTORY
#define O_DIRECTORY 0
#endif
Comment 3 Patrick Welche 2014-10-01 11:18:46 UTC 
Created attachment 287506 [details] [review]
more readable fix

Yes, that is neater!
Comment 4 Patrick Welche 2014-11-06 08:45:49 UTC 
Good to commit (trivial O_DIRECTORY fix)
Comment 5 Patrick Welche 2014-11-08 22:21:35 UTC 
I forgot the question mark - presumably OK to commit the trivial O_DIRECTORY fix?
Comment 6 Bastien Nocera 2015-08-03 16:14:54 UTC 
This isn't needed since 3.15.90, as gsystem use was removed.