After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737359 - matroskademux: returns FLOW_FLUSHING when trying to reuse it
matroskademux: returns FLOW_FLUSHING when trying to reuse it
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-25 12:44 UTC by Jonas Holmberg
Modified: 2014-09-25 15:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add gst_flow_combiner_clear() (6.54 KB, patch)
2014-09-25 12:59 UTC, Jonas Holmberg 		none Details | Review
Remove pads from flow combiner in gst_matroska_demux_reset() (1.00 KB, patch)
2014-09-25 13:10 UTC, Jonas Holmberg 		committed Details | Review
Add gst_flow_combiner_clear() (6.53 KB, patch)
2014-09-25 13:17 UTC, Jonas Holmberg 		committed Details | Review

Description Jonas Holmberg 2014-09-25 12:44:17 UTC 
matroska mux returns GST_FLOW_FLUSHING after state changes PLAYING -> READY -> PLAYING. It is caused by old pads in the flow combiner.
Comment 1 Jonas Holmberg 2014-09-25 12:59:09 UTC 
Created attachment 287070 [details] [review]
Add gst_flow_combiner_clear()

Added gst_flow_combiner_clear() that can be called from gst_matroska_demux_reset().
Comment 2 Jonas Holmberg 2014-09-25 13:10:14 UTC 
Created attachment 287072 [details] [review]
Remove pads from flow combiner in gst_matroska_demux_reset()
Comment 3 Jonas Holmberg 2014-09-25 13:17:59 UTC 
Created attachment 287079 [details] [review]
Add gst_flow_combiner_clear()

Since 1.6
Comment 4 Tim-Philipp Müller 2014-09-25 15:19:21 UTC 
commit 4a304a777487db47a0bdfcb6b52a117bbf58b37b
Author: Jonas Holmberg <jonashg@axis.com>
Date:   Thu Sep 25 14:54:23 2014 +0200

    flowcombiner: add a gst_flow_combiner_clear() method
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737359
    
    API: gst_flow_combiner_clear()


commit 1371fa0c61ccb7ae79bad8ac5796b9c68ac88012
Author: Jonas Holmberg <jonashg@axis.com>
Date:   Thu Sep 25 15:01:14 2014 +0200

    matroskademux: make demuxer reusable
    
    Remove pads from flow combiner and reset last
    flow return to FLOW_OK by resetting the flow combiner.
    This prevents FLOW_FLUSHING when trying to re-use the
    demuxer after setting it back to NULL/READY state.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737359