After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737275 - gobject-introspection-1.42.0 breaks lgi
gobject-introspection-1.42.0 breaks lgi
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
3.14.1
Depends on:
Blocks:
 
 
Reported: 2014-09-24 16:39 UTC by Heiko Becker
Modified: 2015-02-07 16:56 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Heiko Becker 2014-09-24 16:39:25 UTC
To be honest I know next to nothing about this codebase but apparently commit eab36c0001e22c0ee66246ae9a0b8018b2325c96 breaks building the tests of lgi (https://github.com/pavouk/lgi) with the following error. I'm not sure how this include is supposed to work:

/var/tmp/paludis/build/dev-lua-lgi-0.8.0-r3/work/LUA_ABIS/5.2/lgi-0.8.0 /var/tmp/paludis/build/dev-lua-lgi-0.8.0-r3/work
make -j5 LUA=/usr/bin/lua5.2 check
make -C lgi
make[1]: Entering directory '/var/tmp/paludis/build/dev-lua-lgi-0.8.0-r3/work/LUA_ABIS/5.2/lgi-0.8.0/lgi'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/var/tmp/paludis/build/dev-lua-lgi-0.8.0-r3/work/LUA_ABIS/5.2/lgi-0.8.0/lgi'
make -C tests check
make[1]: Entering directory '/var/tmp/paludis/build/dev-lua-lgi-0.8.0-r3/work/LUA_ABIS/5.2/lgi-0.8.0/tests'
pkg-config --exists 'gio-2.0 cairo cairo-gobject gobject-introspection-1.0 gmodule-2.0 libffi >= 0.10.8' --print-errors
touch .depcheck
x86_64-pc-linux-gnu-gcc -fPIC   -I/usr/include/cairo -I/usr/include/pixman-1  -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/gobject-introspection-1.0 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi-3.1/include   -march=native -pipe -O2 -floop-block -floop-interchange -floop-strip-mine -c -o regress.o /usr/share/gobject-introspection-1.0/tests/regress.c
/usr/share/gobject-introspection-1.0/tests/regress.c:2:20: fatal error: config.h: No such file or directory
 #include "config.h"
                    ^
compilation terminated.
Makefile:67: recipe for target 'regress.o' failed
make[1]: Leaving directory '/var/tmp/paludis/build/dev-lua-lgi-0.8.0-r3/work/LUA_ABIS/5.2/lgi-0.8.0/tests'
make[1]: *** [regress.o] Error 1
Makefile:31: recipe for target 'check' failed
make: *** [check] Error 2
Comment 1 Emmanuele Bassi (:ebassi) 2014-09-25 18:08:32 UTC
I think it could be fixed by doing

  #ifdef HAVE_CONFIG_H
  #include "config.h"
  #endif

in regress.c; this way, if we let other people embed this code in their own projects, at least they'll have a fighting chance at building it.

will likely need a comment above the #ifdef, mentioning this bug.
Comment 2 Matthias Clasen 2014-09-26 19:47:04 UTC
would be good to fix for 3.14.1
Comment 3 Matthias Clasen 2014-10-10 15:37:24 UTC
Pushed the suggested fix
Comment 4 André Klapper 2015-02-07 16:56:33 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]