After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737143 - Include <stdint.h> in glib/valgrind.h
Include <stdint.h> in glib/valgrind.h
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-09-22 20:56 UTC by Hib Eris
Modified: 2014-09-23 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Include <stdint.h> in glib/valgrind.h (1.00 KB, patch)
2014-09-22 20:57 UTC, Hib Eris 		reviewed Details | Review
Include <stdint.h> in glib/valgrind.h (1.03 KB, patch)
2014-09-23 07:24 UTC, Hib Eris 		committed Details | Review

Description Hib Eris 2014-09-22 20:56:49 UTC 
This ensures the uintptr_t type is defined on mingw-w64.

Fixes compile error:

make[4]: Entering directory
`/home/abuild/rpmbuild/BUILD/glib-2.42.0/gobject'
  CC       libgobject_2_0_la-gtype.lo
In file included from gtype.c:24:0:
../glib/valgrind.h: In function 'VALGRIND_PRINTF':
../glib/valgrind.h:5601:4: error: unknown type name 'uintptr_t'
    uintptr_t _qzz_res;
    ^
Comment 1 Hib Eris 2014-09-22 20:57:08 UTC 
Created attachment 286843 [details] [review]
Include <stdint.h> in glib/valgrind.h
Comment 2 Colin Walters 2014-09-23 01:57:38 UTC 
Review of attachment 286843 [details] [review]:

Hmm...I think this at least needs some #ifdef fu, since old Windows or something don't have it.

git grep stdint will show you examples.
Comment 3 Hib Eris 2014-09-23 07:24:28 UTC 
Created attachment 286851 [details] [review]
Include <stdint.h> in glib/valgrind.h

This ensures the uintptr_t type is defined on mingw-w64.

Fixes compile error:

make[4]: Entering directory
`/home/abuild/rpmbuild/BUILD/glib-2.42.0/gobject'
  CC       libgobject_2_0_la-gtype.lo
In file included from gtype.c:24:0:
../glib/valgrind.h: In function 'VALGRIND_PRINTF':
../glib/valgrind.h:5601:4: error: unknown type name 'uintptr_t'
    uintptr_t _qzz_res;
    ^
Comment 4 Colin Walters 2014-09-23 13:07:46 UTC 
Review of attachment 286851 [details] [review]:

Ok.
Comment 5 Colin Walters 2014-09-23 13:08:42 UTC 
Attachment 286851 [details] pushed as e1b84e3 - Include <stdint.h> in glib/valgrind.h