After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737142 - Remove remaining gtk deprecation warnings
Remove remaining gtk deprecation warnings
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
: 732987 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-09-22 20:40 UTC by Kris Thomsen
Modified: 2014-10-09 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (2.88 KB, patch)
2014-09-22 20:42 UTC, Kris Thomsen 		accepted-commit_now Details | Review
Removed deprecated gtk stuff code side (3.42 KB, patch)
2014-09-24 21:06 UTC, Kris Thomsen 		none Details | Review
Little clean up patch (2.27 KB, patch)
2014-09-24 21:07 UTC, Kris Thomsen 		none Details | Review

Description Kris Thomsen 2014-09-22 20:40:43 UTC 
The remaining gtk deprecation warnings should be removed.

Still some issues in:
ArtistAlbumsWidget.ui
ArtistAlbumWidget.ui
PlaylistControls.ui
Comment 1 Kris Thomsen 2014-09-22 20:42:37 UTC 
Created attachment 286840 [details] [review]
Proposed patch
Comment 2 Vadim Rutkovsky 2014-09-23 09:42:52 UTC 
Review of attachment 286840 [details] [review]:

Looks good, could you also check that in python code we don't set any nasty deprecated properties in runtime?
Comment 3 Kris Thomsen 2014-09-23 19:53:51 UTC 
I'll give it a try :) But I will only look for gtk-properties.
Should I add them to a new bug report or just to this one?
Comment 4 Vadim Rutkovsky 2014-09-24 07:10:56 UTC 
(In reply to comment #3)
> Should I add them to a new bug report or just to this one?

Yeah, lets reuse this one
Comment 5 Kris Thomsen 2014-09-24 21:06:26 UTC 
Created attachment 287016 [details] [review]
Removed deprecated gtk stuff code side
Comment 6 Kris Thomsen 2014-09-24 21:07:26 UTC 
Created attachment 287017 [details] [review]
Little clean up patch

Forgot to remove some comments. And found another little deprecation.

I think I got everything now.
Comment 7 Vadim Rutkovsky 2014-10-03 11:57:47 UTC 
Thanks! No deprecations found, pushed those to master and gnome-3-14 branches
Comment 8 Vadim Rutkovsky 2014-10-09 15:00:32 UTC 
*** Bug 732987 has been marked as a duplicate of this bug. ***