After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737072 - videopool: add missing annotation for gst_video_buffer_pool_new()
videopool: add missing annotation for gst_video_buffer_pool_new()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal trivial
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-21 11:18 UTC by Ognyan Tonchev (redstar_)
Modified: 2014-09-24 08:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videopool: add missing annotation for gst_video_buffer_pool_new() (879 bytes, patch)
2014-09-21 11:18 UTC, Ognyan Tonchev (redstar_) 		needs-work Details | Review
videopool: add missing annotation for gst_video_buffer_pool_new() (882 bytes, patch)
2014-09-24 07:37 UTC, Ognyan Tonchev (redstar_) 		committed Details | Review

Description Ognyan Tonchev (redstar_) 2014-09-21 11:18:28 UTC 
Created attachment 286729 [details] [review]
videopool: add missing annotation for gst_video_buffer_pool_new()

videopool: add missing annotation for gst_video_buffer_pool_new()
Comment 1 Sebastian Dröge (slomo) 2014-09-23 16:38:25 UTC 
Comment on attachment 286729 [details] [review]
videopool: add missing annotation for gst_video_buffer_pool_new()

This should be (transfer floating)
Comment 2 Tim-Philipp Müller 2014-09-23 16:46:55 UTC 
> This should be (transfer floating)

Should it? GstBufferPool is a mini object.
Comment 3 Sebastian Dröge (slomo) 2014-09-23 16:55:52 UTC 
It's a GstObject, and gst_buffer_pool_new() has (transfer floating)
Comment 4 Ognyan Tonchev (redstar_) 2014-09-24 07:37:37 UTC 
Created attachment 286947 [details] [review]
videopool: add missing annotation for  gst_video_buffer_pool_new()

Here comes a new patch, thanks. I noticed that buffer_pool_new() was transfer floating but this sounded a bit confusing to me:

transfer floating
Alias for transfer none, used for objects with floating refs
Comment 5 Sebastian Dröge (slomo) 2014-09-24 08:03:03 UTC 
commit 00b43badc7830db563d40555ee962ebe2e7c9dd8
Author: Ognyan Tonchev <otonchev@gmail.com>
Date:   Sun Sep 21 13:16:43 2014 +0200

    videopool: add missing annotation for gst_video_buffer_pool_new()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737072