After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736942 - androidmedia: logical disjunction consecutive goto, break statements
androidmedia: logical disjunction consecutive goto, break statements
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-19 05:20 UTC by Anuj
Modified: 2014-11-08 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
androidmedia: logical disjunction consecutive goto, break statements (1.01 KB, patch)
2014-09-19 05:20 UTC, Anuj 		committed Details | Review

Description Anuj 2014-09-19 05:20:34 UTC 
Created attachment 286565 [details] [review]
androidmedia: logical disjunction consecutive goto, break statements

androidmedia:  in gstamcvideodec.c logical disjunction consecutive goto, break statements
Comment 1 Luis de Bethencourt 2014-09-23 16:19:52 UTC 
The breaks are left there to make the code more legible. It is a style issue, and since the code never gets there (since it goes to the goto) it doesn't affect anything.

Sorry but I am going to decline this patch to keep the style consistent over GStreamer.
Comment 2 Luis de Bethencourt 2014-09-23 17:01:19 UTC 
Review of attachment 286565 [details] [review]:

As stated above
Comment 3 Luis de Bethencourt 2014-09-24 11:08:52 UTC 
Comment on attachment 286565 [details] [review]
androidmedia: logical disjunction consecutive goto, break statements

After some more discussion this has been accepted.

Will fix the commit message myself.
Comment 4 Luis de Bethencourt 2014-09-24 11:12:59 UTC 
Comment on attachment 286565 [details] [review]
androidmedia: logical disjunction consecutive goto, break statements

Merged