After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736745 - external tools: links in sbt output are unrecognized
external tools: links in sbt output are unrecognized
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-16 13:14 UTC by Adam Dingle
Modified: 2019-03-23 20:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.88 KB, patch)
2014-09-16 13:44 UTC, Adam Dingle 		accepted-commit_now Details | Review

Description Adam Dingle 2014-09-16 13:14:37 UTC 
sbt is probably the most popular tool for building Scala code.  Its output looks like this:

[error] /home/adam/rt/rt.scala:6: not found: value xyz
[error]   xyz
[error]   ^
[warn] /home/adam/rt/rt.scala:2: implicit conversion method double2test should be enabled

The external tools plugin currently cannot recognize links in this output (it's confused by the [error] and [warn] prefixes).
Comment 1 Ignacio Casal Quinteiro (nacho) 2014-09-16 13:25:33 UTC 
If somebody wants to try to fix this it would be a matter of extending the regexes on:
https://git.gnome.org/browse/gedit/tree/plugins/externaltools/tools/linkparsing.py

and providing the appropriate unit test:
https://git.gnome.org/browse/gedit/tree/plugins/externaltools/tools/linkparsing_test.py
Comment 2 Adam Dingle 2014-09-16 13:44:12 UTC 
Created attachment 286296 [details] [review]
fix

Here's a fix.  :)
Comment 3 Ignacio Casal Quinteiro (nacho) 2014-09-16 13:49:36 UTC 
Review of attachment 286296 [details] [review]:

Looks good to me.
Comment 4 Adam Dingle 2014-09-16 18:40:55 UTC 
OK - I just landed this, and also backported it to the gnome-3-12 and gnome-3-10 branches.