After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736689 - Links with ? (questionmark) in them will not be applied to text selections
Links with ? (questionmark) in them will not be applied to text selections
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: composer
0.6.x
Other Linux
: Normal normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
review
Depends on:
Blocks:
 
 
Reported: 2014-09-15 16:43 UTC by Jean-François Fortin Tam
Modified: 2014-09-18 20:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screencast (133.94 KB, video/webm)
2014-09-15 16:43 UTC, Jean-François Fortin Tam 		  Details
Re-establish selection after link dialog runs (3.55 KB, patch)
2014-09-16 02:59 UTC, Robert Schroll 		committed Details | Review

Description Jean-François Fortin Tam 2014-09-15 16:43:53 UTC 
Created attachment 286222 [details]
screencast

Select some text and try to link https://drive.google.com/?pli=1&authuser=0
or just https://drive.google.com/?

Screencast attached.
Comment 1 Robert Schroll 2014-09-16 02:59:13 UTC 
Created attachment 286251 [details] [review]
Re-establish selection after link dialog runs

The problem isn't that the link has a question mark; the problem is that 
you selected text in the link dialog that last time.  This caused the 
selection in the editor to disappear before we ran the linkification.

Oddly, we have some code that corrected for this, but only when the 
selected text was a link.  We really need to do it all the time, and 
that's what this patch does.
Comment 2 Jim Nelson 2014-09-18 20:37:28 UTC 
Review of attachment 286251 [details] [review]:

Commit!
Comment 3 Robert Schroll 2014-09-18 20:57:46 UTC 
Attachment 286251 [details] pushed as 6c4c291 - Re-establish selection after link dialog runs