GNOME Bugzilla – Bug 736641
"Edit Filesystem..." option is labeled wrong, should be "Edit Filesystem Label..."
Last modified: 2018-05-24 10:31:24 UTC
In the "More actions" menu for the volumes, the "Edit Filesystem..." option should be renamed to "Edit Filesystem Label..." because that's what it does. The current string is wrong. I've seen this bug first in Ubuntu, then also in Debian sid. If I'm not mistaken, the problem is in src/disks/ui/disks.ui, around line 1120: <child> <object class="GtkMenuItem" id="generic-menu-item-edit-label"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="label" translatable="yes">Edit Filesystem…</property> <property name="use_underline">True</property> </object> </child> The label is "Edit Filesystem..." but should be "Edit Filesystem Label...", or similar. When clicked, it opens the dialog to change the label of the partition. And the id of the object "generic-menu-item-edit-label" also gives away that fact.
I found this entry in the NEWS file: 'Use "Edit Filesystem…" instead of "Edit Filesystem Label…"' What's the reason for this change?
I have the same problem as OP. Using Linux Mint 18.2 XFCE.
The change was intentional, see commit ff76e10 description for more details...
@Ondrej, Thanks for the link. Having read the link you provided, The description says, > "The word "label" is overloaded and in the future we may allow editing more than just the label itself. I don't understand. What does it mean for the word "label" to be overloaded? Let's grant that "in the future [they] may allow editing more than just the label itself". Still, that's a future possibility. The current reality is different though. The current reality is that the entry "Edit Filesystem" is misleading. The current reality is that "Edit Filesystem Label" is a more descriptive, more accurate entry. "Edit Filesystem Label" tells me what to expect when I click it. A while ago, I was looking to rename my drive's label from something like 3843-383p83uoeshoetho to "HDD2". I looked at gnome-disk-utility, and saw "Edit Filesystem" but just bypassed it. Why did I bypass it? Because I was not looking to edit the filesystem (whatever that means). I was looking to rename the filesystem or to edit the filesystem label. And to think that this change was intentional really baffles me. It's an unintentionally but ultimately confusing change. You're the "developer". Don't you have a say?
Hi, I've also thought about changing it already, but if you have a look on 'Edit Partition' it is consistent. Because there you can edit the label of a GPT partition along with some flags etc. Maybe we can do it better when the mockups are implemented.
Hi Kai. Thanks for your reply. > I've also thought about changing it already, but if you have a look on 'Edit Partition' it is consistent. Because there you can edit the label of a GPT partition along with some flags etc. Gently... Consistency could be a good thing. But should we seek consistency if by so doing we are consistenly inaccurate. It's better to be inconsistent, if we are accurate. > Maybe we can do it better when the mockups are implemented. What mockups? And when will the mockups be implemented?
It's planned to meet at GUADEC to rework them, but that would be the direction: https://bugzilla.gnome.org/show_bug.cgi?id=737671
This won't land in the next release. So I suggest that editing the partition label is moved out of the "Edit Partition" dialog to "Edit Partition Label" since the two labels can be easily confused. Then renaming "Edit Filesystem Label" makes sense. Ideally these actions are directly available where the label itself is presented, but this is not possible with the current volumes widget.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-disk-utility/issues/27.