After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736609 - Process Fields Scanner: capitalization issues
Process Fields Scanner: capitalization issues
Status: RESOLVED FIXED
Product: easytag
Classification: Other
Component: general
master
Other Linux
: Normal normal
: 2.2
Assigned To: EasyTAG maintainer(s)
EasyTAG maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-13 09:17 UTC by Steven P. Ulrick
Modified: 2014-09-13 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Steven P. Ulrick 2014-09-13 09:17:52 UTC
"Capitalize the first letter of each word" does not work like it used to.

Used to be if I took a file name that looked like this:
04 - like to get to know you (single version).mp3

that this is how it would look if I selected "Capitalize the first letter of each word" on the "Process Fields Scanner":
04 - Like To Get To Know You (Single Version).mp3

On a copy of easytag updated from GIT and compiled on September 9th, this is the result if I select and apply "Capitalize the first letter of each word" on the "Process Fields Scanner":
04 - Like to Get to Know You (Single Version).mp3

"Capitalize all", "Lowercase all" & "Capitalize first letter" all work as expected.
Comment 1 David King 2014-09-13 09:28:38 UTC
You probably have the "Upper-case the first letters of all words" option disabled in the scanner preferences (which is the default). This option does not upper-case the first letters of prepositions and articles, as well as some other short words. We have struggled with the wording for the option a bit, and the placement in the preferences (separate from the scanner dialogue) is a bit problematic too. I have added a note in the Etherpad about improving the documentation, which should help a bit.
Comment 2 Steven P. Ulrick 2014-09-13 09:59:26 UTC
Yes, I did have that unchecked.  Well, actually that appears to be the default...  In any case, I checked that box and tried again.  The results were NOT what I expected!  

This filename:
01 - Sunday Will Never Be The Same (Album Version) - Spanky & Our Gang


turned into this:
01 - Sunday Will never be the same (Album version) - Spanky & Our Gang

You will notice that the first two words were capitalized, and everything else in the title field was made lowercase.  That behavior was different when I had Upper-Case the first letter of all words" unchecked.

When I uncheck that box and try again, you will see here that the result is different:
01 - Sunday Will Never Be the Same (Album Version) - Spanky & Our Gang
Comment 3 Steven P. Ulrick 2014-09-13 10:01:10 UTC
I actually tried this with the setting you referred to on all the tracks of this album.  The results were the same on all the files.  First two words of the Title field capitalized, everything else lowercase.
Comment 4 Steven P. Ulrick 2014-09-13 10:07:05 UTC
I just noticed that this was "Resolved | NOTABUG"  I assume that you did this before I actually tried the setting you referred to?  Assuming that this is not a bug, the fact still remains that using the obvious setting the Scanner, as well as the other setting in Preferences does not accomplish what those two settings seem to say that they do.  If that is the case, how do I capitalize the first letter of all the words?  If this is NOTABUG, the fact still remains that I can't use easytag to capitalize the first letters of each word...
Comment 5 Steven P. Ulrick 2014-09-13 10:21:37 UTC
One more question/comment.  How should I capitalize the first letter of each word on easytag?  I have tried different combinations of the settings in the scanner itself as well as "Edit | Preferences" with no good results.  I have tried removing "~/.config/easytag" and starting fresh.  Still, nothing works.

But, if I go back to an copy of Easytag that I updated and compiled back on July 30, everything works as expected, and as I remember it.
Comment 6 David King 2014-09-13 18:24:40 UTC
I had the boolean check for whether to enable the "do not upper-case prepositions" feature the wrong way round, so I just fixed that on master. You should now be able to upper-case the first letter of each word by making sure that the option is enabled in the scanner preferences.

I can now reproduce the bug that you found where only the first 2 words are capitalized, so I have reopened the bug.
Comment 7 David King 2014-09-13 21:49:05 UTC
I just pushed a further fix to master, which correctly processes the whole string, rather than just the first 2 words. Thanks for the report!