After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736329 - appDisplay: Only allow ctrl-click for apps that can open new windows
appDisplay: Only allow ctrl-click for apps that can open new windows
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-09 13:26 UTC by Florian Müllner
Modified: 2014-09-09 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
appDisplay: Only allow ctrl-click for apps that can open new windows (1.38 KB, patch)
2014-09-09 13:26 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2014-09-09 13:26:28 UTC
See patch.
Comment 1 Florian Müllner 2014-09-09 13:26:33 UTC
Created attachment 285740 [details] [review]
appDisplay: Only allow ctrl-click for apps that can open new windows

Trust the heuristics in shell_app_can_open_new_window() to get it right
more often than not, and add an appropriate check in activate(). This
makes the behavior consistent with the dash, e.g. we will try to open
a new window (and show the corresponding animation) for apps that don't
have a "New window" item in their dash context menu.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-09-09 13:39:16 UTC
Review of attachment 285740 [details] [review]:

OK.
Comment 3 Florian Müllner 2014-09-09 13:58:04 UTC
Attachment 285740 [details] pushed as 491100c - appDisplay: Only allow ctrl-click for apps that can open new windows