After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736203 - [regression] GtkCellRendererAccel doesn't work in modal dialogues
[regression] GtkCellRendererAccel doesn't work in modal dialogues
Status: VERIFIED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-09-06 18:55 UTC by Bastien Nocera
Modified: 2014-09-08 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
prefs.js (4.57 KB, application/x-javascript)
2014-09-06 18:55 UTC, Bastien Nocera 		Details

Description Bastien Nocera 2014-09-06 18:55:48 UTC 
Created attachment 285583 [details]
prefs.js

Reproducer attached.

Reverting fe5402d32ebf7f332a2c5f71b9ae50dcf68892fd fixed the problem.
Comment 1 Matthias Clasen 2014-09-06 23:03:49 UTC 
Reverted, and fixed in a different way.
Comment 2 Bastien Nocera 2014-09-07 00:11:50 UTC 
Tested it and it breaks the fix to "cannot remap F1 to another function" bug in gnome-control-center:
- Open gnome-control-center
- Go to keyboard -> Shortcuts
- Try to remap one of the actions to F1

With Jasper's fix it will work, without it, it won't even take the cell renderer out of "capture" mode. The help will be launched but you won't be able to click to close it as the cell renderer is capturing the pointer and the keyboard.
Comment 3 Matthias Clasen 2014-09-07 00:38:23 UTC 
hmm, I did test that I could choose keys that have existing bindings - thats why I reintroduced the keyboard grab. Without it, you would get what you describe - exising passive grabs prevent us from seeing e.g. F1. I'll investigate some more
Comment 4 Matthias Clasen 2014-09-07 00:39:26 UTC 
oh, I see, the difference is that F1 is bound by the control-center itself
Comment 5 Bastien Nocera 2014-09-08 15:55:48 UTC 
None of the 2 possible bugs mentioned above appear. Success!