After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736117 - Fixes a crash if the WM changes (or restarts)
Fixes a crash if the WM changes (or restarts)
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-05 10:52 UTC by Bastien Nocera
Modified: 2014-09-05 12:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keyboard: Make it possible to stop watching for WM changes (1.95 KB, patch)
2014-09-05 10:52 UTC, Bastien Nocera
committed Details | Review
keyboard: Fixes a crash if the WM changes (or restarts) (2.52 KB, patch)
2014-09-05 10:52 UTC, Bastien Nocera
none Details | Review
keyboard: Fix a crash if the WM changes (or restarts) (2.52 KB, patch)
2014-09-05 10:55 UTC, Bastien Nocera
none Details | Review
keyboard: Fix a crash if the WM changes (or restarts) (2.27 KB, patch)
2014-09-05 10:56 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2014-09-05 10:52:33 UTC
.
Comment 1 Bastien Nocera 2014-09-05 10:52:37 UTC
Created attachment 285472 [details] [review]
keyboard: Make it possible to stop watching for WM changes

As we don't want to be doing that anymore if we're not in the keyboard
panel anymore.
Comment 2 Bastien Nocera 2014-09-05 10:52:42 UTC
Created attachment 285473 [details] [review]
keyboard: Fixes a crash if the WM changes (or restarts)

By stopping watching for WM changes when leaving the shortcuts panel.

 #0 reload_sections
 #1 wm_window_event_filter
 #2 gdk_event_apply_filters at gdkeventsource.c:81
 #3 gdk_event_source_translate_event at gdkeventsource.c:195
 #4 _gdk_x11_display_queue_events at gdkeventsource.c:338
 #5 gdk_display_get_event at gdkdisplay.c:313
 #10 g_main_context_iteration at gmain.c:3766
 #11 g_application_run at gapplication.c:1623

See https://bugzilla.redhat.com/show_bug.cgi?id=1094480
Comment 3 Bastien Nocera 2014-09-05 10:55:03 UTC
Created attachment 285474 [details] [review]
keyboard: Fix a crash if the WM changes (or restarts)

By stopping watching for WM changes when leaving the shortcuts panel.

 #0 reload_sections
 #1 wm_window_event_filter
 #2 gdk_event_apply_filters at gdkeventsource.c:81
 #3 gdk_event_source_translate_event at gdkeventsource.c:195
 #4 _gdk_x11_display_queue_events at gdkeventsource.c:338
 #5 gdk_display_get_event at gdkdisplay.c:313
 #10 g_main_context_iteration at gmain.c:3766
 #11 g_application_run at gapplication.c:1623

See https://bugzilla.redhat.com/show_bug.cgi?id=1094480
Comment 4 Bastien Nocera 2014-09-05 10:56:31 UTC
Created attachment 285475 [details] [review]
keyboard: Fix a crash if the WM changes (or restarts)

By stopping watching for WM changes when leaving the shortcuts panel.

 #0 reload_sections
 #1 wm_window_event_filter
 #2 gdk_event_apply_filters at gdkeventsource.c:81
 #3 gdk_event_source_translate_event at gdkeventsource.c:195
 #4 _gdk_x11_display_queue_events at gdkeventsource.c:338
 #5 gdk_display_get_event at gdkdisplay.c:313
 #10 g_main_context_iteration at gmain.c:3766
 #11 g_application_run at gapplication.c:1623

See https://bugzilla.redhat.com/show_bug.cgi?id=1094480
Comment 5 Rui Matos 2014-09-05 12:12:58 UTC
Review of attachment 285472 [details] [review]:

looks good
Comment 6 Rui Matos 2014-09-05 12:13:29 UTC
Review of attachment 285475 [details] [review]:

yes
Comment 7 Bastien Nocera 2014-09-05 12:17:21 UTC
Attachment 285472 [details] pushed as 6c43ebe - keyboard: Make it possible to stop watching for WM changes
Attachment 285475 [details] pushed as 439eb22 - keyboard: Fix a crash if the WM changes (or restarts)