Created attachment 285383 [details] [review]
gstextractor.c

Review of attachment 285383 [details] [review]:

This code look good in general. As an example it should probably be commented, what do you think ?

::: tests/examples/gstextractor.c
@@ +1,1 @@
+/*

Normally there should be copyright and licensing here. For an example you can make it as-is, it's your choice.

@@ +54,3 @@
+  g_strfreev (timev);
+  return (guint64) (time * GST_SECOND);
+}

Just wondering, but can't gst_date_time_new_from_iso8601_string() can be used here ? We do this kind of conversion in GST in general, I would be suprised if there is no utility for it.

Created attachment 285547 [details] [review]
gstextractor.c updated

updated gstextractor.c with comments and license information.

Created attachment 285548 [details]
testgdatetime.c

I haved tested gst_date_time_new_from_iso8601_string(), Here is some observations. Test code attached(testgstdatetime.c)

1. gst_date_time_new_from_iso8601_string() expects date must be present (like YYYY-MM-DD).
2. There is no way to get combined seconds from gst_date_time_* api (HH * 60 * 60 + MM * 60 + SS). We have to take hours, minutes, seconds seperately and then do the calculation manually.

It will be helpful to developers if we have a function in gst_date_time_* api to directly get nanoseconds instead of developers doing the nanoseconds calculation.

Created attachment 285549 [details]
testgstdatetime.c

Any chance of getting this new patch reviewed?

GNL is now dead and the non linear video edition feature is now implement as part of NLE currently hidden inside the GStreamer editing services. The goal though is to stabilize the NLE implementation and API (which has an API pretty similar to what GNL used to have) and move it all in gst-plugins-base.

I keep that bug open as this example would be should be ported to NLE and added in -base when the move of NLE in there happens.

Thanks for the patch but no activity happened in the last 4 years and noone seem to care enough to port the example. Closing.