After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735921 - Test suite fixes/improvements
Test suite fixes/improvements
Status: RESOLVED FIXED
Product: librest
Classification: Platform
Component: other
git master
Other Linux
: Normal normal
: ---
Assigned To: librest-maint
librest-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-02 19:48 UTC by Christophe Fergeau
Modified: 2014-09-03 08:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Don't call g_type_init() on newer glib (8.70 KB, patch)
2014-09-02 19:50 UTC, Christophe Fergeau 		committed Details | Review
tests: Don't call soup_message_headers_get with newer libsoup (800 bytes, patch)
2014-09-02 19:50 UTC, Christophe Fergeau 		committed Details | Review
tests: Remove unused 'session' variable (2.76 KB, patch)
2014-09-02 19:50 UTC, Christophe Fergeau 		committed Details | Review
tests: Remove more unused variables/code (1.52 KB, patch)
2014-09-02 19:50 UTC, Christophe Fergeau 		committed Details | Review
tests/oauth: Use oauthbin.com as the test server (5.17 KB, patch)
2014-09-02 19:50 UTC, Christophe Fergeau 		committed Details | Review
tests/lastfm: Fix memory leak (651 bytes, patch)
2014-09-02 19:50 UTC, Christophe Fergeau 		committed Details | Review
tests/proxy: Fix memory leaks (3.01 KB, patch)
2014-09-02 19:50 UTC, Christophe Fergeau 		committed Details | Review
tests/proxy: Make sure GError is unset when call succeeds (1.73 KB, patch)
2014-09-02 19:50 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2014-09-02 19:48:51 UTC 
A bunch of fixes for failing test cases, or leak/warning fixes.
Comment 1 Christophe Fergeau 2014-09-02 19:50:00 UTC 
Created attachment 285177 [details] [review]
tests: Don't call g_type_init() on newer glib

This is deprecated and causes a compile warning
Comment 2 Christophe Fergeau 2014-09-02 19:50:06 UTC 
Created attachment 285178 [details] [review]
tests: Don't call soup_message_headers_get with newer libsoup

This is deprecated and causes compile-time warnings
Comment 3 Christophe Fergeau 2014-09-02 19:50:12 UTC 
Created attachment 285179 [details] [review]
tests: Remove unused 'session' variable
Comment 4 Christophe Fergeau 2014-09-02 19:50:18 UTC 
Created attachment 285180 [details] [review]
tests: Remove more unused variables/code
Comment 5 Christophe Fergeau 2014-09-02 19:50:25 UTC 
Created attachment 285181 [details] [review]
tests/oauth: Use oauthbin.com as the test server

The tests used to use term.ie which is gone.
There are still some intermittent failures when running the tests,
sometimes the test is successful, sometimes it's not :(
Comment 6 Christophe Fergeau 2014-09-02 19:50:31 UTC 
Created attachment 285182 [details] [review]
tests/lastfm: Fix memory leak
Comment 7 Christophe Fergeau 2014-09-02 19:50:37 UTC 
Created attachment 285183 [details] [review]
tests/proxy: Fix memory leaks
Comment 8 Christophe Fergeau 2014-09-02 19:50:44 UTC 
Created attachment 285184 [details] [review]
tests/proxy: Make sure GError is unset when call succeeds
Comment 9 Marc-Andre Lureau 2014-09-02 21:01:08 UTC 
Review of attachment 285177 [details] [review]:

ack
Comment 10 Marc-Andre Lureau 2014-09-02 21:03:38 UTC 
Review of attachment 285178 [details] [review]:

ack
Comment 11 Marc-Andre Lureau 2014-09-02 21:04:38 UTC 
Review of attachment 285179 [details] [review]:

ack
Comment 12 Marc-Andre Lureau 2014-09-02 21:04:54 UTC 
Review of attachment 285180 [details] [review]:

ack
Comment 13 Marc-Andre Lureau 2014-09-02 21:12:54 UTC 
Review of attachment 285181 [details] [review]:

who is maintaining oauthbin? Isn't there other more popular oauth server that could be used? (I don't know much about oauth)
Comment 14 Marc-Andre Lureau 2014-09-02 21:13:09 UTC 
Review of attachment 285182 [details] [review]:

ack
Comment 15 Marc-Andre Lureau 2014-09-02 21:13:09 UTC 
Review of attachment 285182 [details] [review]:

ack
Comment 16 Marc-Andre Lureau 2014-09-02 21:13:24 UTC 
Review of attachment 285184 [details] [review]:

ack
Comment 17 Marc-Andre Lureau 2014-09-02 21:13:35 UTC 
Review of attachment 285183 [details] [review]:

ack
Comment 18 Christophe Fergeau 2014-09-03 07:42:43 UTC 
Review of attachment 285181 [details] [review]:

No clue, oauthbin is the first test oauth server I could find (ie hardcoded credentials, ping service). Most of the other hits I got were about deploying myself some php oauth code from google code.
I'd expect most real oauth server to have switched to oauth2 by now.
Comment 19 Christophe Fergeau 2014-09-03 08:57:55 UTC 
Attachment 285177 [details] pushed as c81d89c - tests: Don't call g_type_init() on newer glib
Attachment 285178 [details] pushed as ec8fffc - tests: Don't call soup_message_headers_get with newer libsoup
Attachment 285179 [details] pushed as 752c645 - tests: Remove unused 'session' variable
Attachment 285180 [details] pushed as 9ecd36a - tests: Remove more unused variables/code
Attachment 285181 [details] pushed as 6942de4 - tests/oauth: Use oauthbin.com as the test server
Attachment 285182 [details] pushed as 75b2da5 - tests/lastfm: Fix memory leak
Attachment 285183 [details] pushed as 0ad11f0 - tests/proxy: Fix memory leaks
Attachment 285184 [details] pushed as 92a0634 - tests/proxy: Make sure GError is unset when call succeeds