After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735911 - Destroy hotspot connection when switching off
Destroy hotspot connection when switching off
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-02 17:15 UTC by Bastien Nocera
Modified: 2021-06-09 16:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
network: destroy hotspot when switching off (1.85 KB, patch)
2014-09-06 04:00 UTC, Michael Catanzaro
none Details | Review

Description Bastien Nocera 2014-09-02 17:15:45 UTC
So that it's not re-enabled by error, and we can change the name of the hotspot without problems, if the computer's name changed.
Comment 1 Michael Catanzaro 2014-09-06 04:00:50 UTC
Created attachment 285550 [details] [review]
network: destroy hotspot when switching off

This works, but I'm marking it as obsolete since we really do not want to do this unless we can find a way to use the same security key each time the hotspot is created.
Comment 2 Bastien Nocera 2014-09-06 12:37:49 UTC
(In reply to comment #1)
> Created an attachment (id=285550) [details] [review]
> network: destroy hotspot when switching off
> 
> This works, but I'm marking it as obsolete since we really do not want to do
> this unless we can find a way to use the same security key each time the
> hotspot is created.

Not being able to change the settings from the original is a problem. We should probably offer a default password but the ability to change it in the "Turn on Hotspot" dialogue. It would allow us to change it, and keep it around as well. Is it security sensitive? Should we save it in the keyring?
Comment 3 Bastien Nocera 2014-09-06 12:39:06 UTC
In the meanwhile, I'd be fine with not allow a hotspot password to be chosen but to keep it around for the next run.
Comment 4 Bastien Nocera 2014-09-06 12:39:33 UTC
(In reply to comment #3)
> In the meanwhile, I'd be fine with not allow a hotspot password to be chosen
> but to keep it around for the next run.

And that would allow us to fix this bug while not changing UI, which means we could land it in 3.14.
Comment 5 Michael Catanzaro 2014-09-06 13:23:35 UTC
(In reply to comment #2)
> Is it security sensitive? Should we save it in the keyring?

Of course!
Comment 6 Michael Catanzaro 2014-09-06 13:46:17 UTC
Review of attachment 285550 [details] [review]:

::: panels/network/net-device-wifi.c
@@ +1180,3 @@
+                    gpointer            user_data)
+{
+        if (error != NULL) {

Is it correct that we don't free GErrors passed to callbacks? Or is the code I copied this from (the function really_forgotten lower in this file) wrong?
Comment 7 André Klapper 2021-06-09 16:08:41 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new bug report at
  https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/

Thank you for your understanding and your help.