After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735896 - typefind: Run the default have-type handler after all application handlers
typefind: Run the default have-type handler after all application handlers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 763491 763625
 
 
Reported: 2014-09-02 14:41 UTC by Sebastian Dröge (slomo)
Modified: 2016-03-14 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
typefind: Run the default have-type handler after all application handlers (1.23 KB, patch)
2014-09-02 14:42 UTC, Sebastian Dröge (slomo) 		committed Details | Review
typefind: Store caps on the pad before emitting have-type but send it downstream only in the default signal handler (3.29 KB, patch)
2016-03-11 14:01 UTC, Sebastian Dröge (slomo) 		rejected Details | Review

Description Sebastian Dröge (slomo) 2014-09-02 14:41:56 UTC 
Otherwise the CAPS event will already be forwarded downstream and the application has no way to intervene anymore.

Not sure if this breaks compatibility with something.
Comment 1 Sebastian Dröge (slomo) 2014-09-02 14:42:29 UTC 
Created attachment 285152 [details] [review]
typefind: Run the default have-type handler after all application handlers

Otherwise the CAPS event will already be forwarded downstream and
the application has no way to intervene anymore.
Comment 2 Sebastian Dröge (slomo) 2015-04-13 07:04:47 UTC 
Saw no problems with this here, so let's just get it in

commit 64094204748e987197783cc7b7e0e98d22e5e2f3
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Sep 2 17:40:28 2014 +0300

    typefind: Run the default have-type handler after all application handlers
    
    Otherwise the CAPS event will already be forwarded downstream and
    the application has no way to intervene anymore.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=735896
Comment 3 Sebastian Dröge (slomo) 2016-03-11 14:01:04 UTC 
Created attachment 323709 [details] [review]
typefind: Store caps on the pad before emitting have-type but send it downstream only in the default signal handler