After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735880 - imagefreeze: replace with gst_buffer_copy
imagefreeze: replace with gst_buffer_copy
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal trivial
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-02 11:52 UTC by Vineeth
Modified: 2014-09-04 00:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.03 KB, patch)
2014-09-02 11:53 UTC, Vineeth 		committed Details | Review

Description Vineeth 2014-09-02 11:52:25 UTC 
In gst_image_freeze_src_loop()

gst_buffer_ref and gst_buffer_writable is being used to create a writable copy of source buffer.

replacing the same with gst_buffer_copy as the functionality is same.

The same can be updated in documentation as well, similar to how gst_caps_copy is defined.

Please review if the patch is proper. Thanks
Comment 1 Vineeth 2014-09-02 11:53:35 UTC 
Created attachment 285130 [details] [review]
proposed patch
Comment 2 Thiago Sousa Santos 2014-09-04 00:42:03 UTC 
Thanks for the patch

commit 6ff397ecccb2dd81189a8f3ec153c7c15a8ef878
Author: Vineeth T M <vineeth.tm@samsung.com>
Date:   Tue Sep 2 17:22:07 2014 +0530

    imagefreeze: replace with gst_buffer_copy
    
    gst_buffer_ref and gst_buffer_writable is being used to create a writable copy of source buffer.
    
    replacing the same with gst_buffer_copy as the functionality is same.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=735880