After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735742 - automake warns INCLUDES is deprecated
automake warns INCLUDES is deprecated
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
GIT HEAD
Other Linux
: Normal normal
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2014-08-31 10:53 UTC by Mike Fleetwood
Modified: 2014-10-20 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace automake INCLUDES variable (v1) (1.15 KB, patch)
2014-08-31 11:12 UTC, Mike Fleetwood 		none Details | Review

Description Mike Fleetwood 2014-08-31 10:53:13 UTC 
Patch following
Comment 1 Mike Fleetwood 2014-08-31 11:12:40 UTC 
Created attachment 284927 [details] [review]
Replace automake INCLUDES variable (v1)

Hi Curtis,

Here's the small fix to prevent this warning.

After running ./autogen.sh look in src/Makefile and see how CXXCOMPILE
includes both INCLUDES and AM_CPPFLAGS to confirm this is safe to do.

Test built successfully on CentOS 5.10.
(Also unnecessarily successfully test built on CentOS 6.5, Debian 6,
Fedora 19, Kubuntu 12.04 LTS and Xubuntu 14.04 LTS).

Thanks,
Mike
Comment 2 Curtis Gedak 2014-08-31 17:48:28 UTC 
Hi Mike,

Thanks for catching and addressing this deprecated name.

I did a quick test to confirm that the patch still builds on the
following two distros:

  kubuntu  12.04
  openSUSE 13.1

There were no problems building with the patch.

The patch in comment #1 has been committed to the git repository for
inclusion in the next release of GParted.

The relevant git commit can be viewed at the following link:

Prevent automake warning about deprecated INCLUDES (#735742)
https://git.gnome.org/browse/gparted/commit/?id=e8533c39c270b2a38f64bf5e9e54eed4a638183b

Curtis
Comment 3 Curtis Gedak 2014-10-20 17:11:09 UTC 
This enhancement was included in the GParted 0.20.0 release on October 20, 2014.