After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735720 - Use the new support for RTL icons in GtkIconTheme
Use the new support for RTL icons in GtkIconTheme
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-30 18:24 UTC by Yosef Or Boczko
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use the new support for RTL icons in GtkIconTheme (2.69 KB, patch)
2014-08-30 18:26 UTC, Yosef Or Boczko 		needs-work Details | Review
build: Require gtk+ >= 3.13.2 (715 bytes, patch)
2014-09-03 10:48 UTC, Yosef Or Boczko 		committed Details | Review
Fix the back icons in RTL (2.34 KB, patch)
2014-09-03 10:48 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2014-08-30 18:24:23 UTC 
See the patch.
Comment 1 Yosef Or Boczko 2014-08-30 18:26:29 UTC 
Created attachment 284899 [details] [review]
Use the new support for RTL icons in GtkIconTheme
Comment 2 Zeeshan Ali 2014-09-01 15:03:22 UTC 
Review of attachment 284899 [details] [review]:

Please keep the short log short and provide details in details section: https://wiki.gnome.org/Git/CommitMessages

::: configure.ac
@@ -53,3 @@
 GOBJECT_INTROSPECTION_MIN_VERSION=0.9.6
 GOVIRT_MIN_VERSION=0.2.0
-GTK_MIN_VERSION=3.11

Please put this in separate patch so I don't forget to mention in release notes.
Comment 3 Yosef Or Boczko 2014-09-03 10:48:30 UTC 
Created attachment 285243 [details] [review]
build: Require gtk+ >= 3.13.2
Comment 4 Yosef Or Boczko 2014-09-03 10:48:53 UTC 
Created attachment 285244 [details] [review]
Fix the back icons in RTL

This is supported by GTK+ itself now.
Comment 5 Zeeshan Ali 2014-09-03 11:01:51 UTC 
Review of attachment 285243 [details] [review]:

ACK
Comment 6 Zeeshan Ali 2014-09-03 11:02:39 UTC 
Review of attachment 285244 [details] [review]:

ack
Comment 7 Yosef Or Boczko 2014-09-03 11:05:59 UTC 
Review of attachment 285243 [details] [review]:

Pushed as 5c24c92 - build: Require gtk+ >= 3.13.2
Comment 8 Yosef Or Boczko 2014-09-03 11:06:21 UTC 
Review of attachment 285244 [details] [review]:

Pushed as 4b6777f - Fix the back icons in RTL