After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735566 - gl: some cleanup and fixes to qglwtextureshare
gl: some cleanup and fixes to qglwtextureshare
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-28 06:16 UTC by comicfans44
Modified: 2014-08-28 07:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
some clean and fix to qglwtextureshare (6.33 KB, patch)
2014-08-28 06:16 UTC, comicfans44 		committed Details | Review

Description comicfans44 2014-08-28 06:16:06 UTC 
Created attachment 284657 [details] [review]
some clean and fix to qglwtextureshare

this patch does some clean and fix to qglwtextureshare:
1.function in glcontextid.h already replaced by gst_gl_context_new_wrapped
2.fix call gst function before calling gst_init
3.flush gstreamer's opengl thread before using the result texture, without this,
  on ATI card, the result texture may not be rendered completely when used in 
  other context, leads weird flicker or random garbage. hopes this hint can 
  help others who uses gstreamer context share within app.
Comment 1 Sebastian Dröge (slomo) 2014-08-28 07:06:55 UTC 
commit 8d6f745b78e8190cebd9061192975ad88a08efd5
Author: Wang Xin-yu (王昕宇) <comicfans44@gmail.com>
Date:   Tue Aug 26 16:21:42 2014 +0800

    gl: qglwtextureshare demo fixes and cleanup
    
    1. glcontextid function is replaced by gstreamer gst_gl_context_new_wrapped .
    2. call gst_init before gst_gl_display_new , seems gst_gl_display_new depends
       on gst_allocator_register , which only worked after gst_init called
    3. flush gstreamer OpenGL context before using shared texture, fix
       flicker problem.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=735566