After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735353 - GtkTreeView::row-activated not emitted sometimes
GtkTreeView::row-activated not emitted sometimes
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-08-25 07:10 UTC by Christoph Reiter (lazka)
Modified: 2014-08-27 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
example (1.43 KB, text/x-python)
2014-08-25 07:10 UTC, Christoph Reiter (lazka) 		  Details
treeview: Reset multipress controller after 2nd click (1.04 KB, patch)
2014-08-27 13:01 UTC, Carlos Garnacho 		committed Details | Review

Description Christoph Reiter (lazka) 2014-08-25 07:10:16 UTC 
Created attachment 284376 [details]
example

This example shows row-activated not being emitted on GTK+ trunk.

To reproduce:

 * Click a selected row lots of times with a speed that should
   activate it each time.
 * Or quickly double click one row after another.

It sometimes works, most times doesn't. The numbers in each row will
increment on activate..
Comment 1 Carlos Garnacho 2014-08-27 13:01:34 UTC 
Created attachment 284600 [details] [review]
treeview: Reset multipress controller after 2nd click

The pre-gestures code used to compare the current button press with the
previous one on !activate_on_single_click, and unset the previous event
data so ::row-activated would be emitted every 2 clicks.

So do the same with the multipress gesture and reset it after every 2nd
click to have ::row-activated emitted multiple times while manic clicking.
Comment 2 Christoph Reiter (lazka) 2014-08-27 13:22:58 UTC 
Can confirm manic clicking working as before. Thanks!
Comment 3 Matthias Clasen 2014-08-27 14:50:28 UTC 
Review of attachment 284600 [details] [review]:

ok. Thanks for the explanatory commit message
Comment 4 Matthias Clasen 2014-08-27 14:53:00 UTC 
Review of attachment 284600 [details] [review]:

ok. Thanks for the explanatory commit message
Comment 5 Carlos Garnacho 2014-08-27 15:15:07 UTC 
Attachment 284600 [details] pushed as e6199af - treeview: Reset multipress controller after 2nd click