After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734826 - Deprecate GtkStatusIcon
Deprecate GtkStatusIcon
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 688493 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-08-15 00:20 UTC by Matthias Clasen
Modified: 2014-08-15 17:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Deprecate GtkStatusIcon (20.79 KB, patch)
2014-08-15 00:21 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2014-08-15 00:20:58 UTC 
GtkStatusIcon is using a problematic, XEmbed-based protocol under X,
and we want to get rid of it eventually. Document our intentions by
marking GtkStatusIcon as deprecated.
Comment 1 Matthias Clasen 2014-08-15 00:21:01 UTC 
Created attachment 283422 [details] [review]
Deprecate GtkStatusIcon
Comment 2 Cosimo Cecchi 2014-08-15 00:24:37 UTC 
*** Bug 688493 has been marked as a duplicate of this bug. ***
Comment 3 Emmanuele Bassi (:ebassi) 2014-08-15 10:53:01 UTC 
Review of attachment 283422 [details] [review]:

looks generally good to me.

::: gtk/gtkstatusicon.c
@@ +31,3 @@
 #include <stdlib.h>
 
+#undef GDK_DEPRECATED

don't we usually use:

#define GDK_DISABLE_DEPRECATION_WARNINGS

before including gdk.h/gtk.h ?

this should also avoid the begin/end ignore deprecations pragma.

::: tests/teststatusicon.c
@@ +23,3 @@
 #include <stdlib.h>
 
+G_GNUC_BEGIN_IGNORE_DEPRECATIONS

probably better to use:

#define GDK_DISABLE_DEPRECATION_WARNINGS
#include <gtk/gtk.h>
Comment 4 Matthias Clasen 2014-08-15 17:04:04 UTC 
Attachment 283422 [details] pushed as cab7dcd - Deprecate GtkStatusIcon